← 输入框|github.com|刷新
Skip to content

Purge dependency on script-editor #2

Open

Description

@ctrueden

This component has a dependency on org.scijava:script-editor so that it can implement a PythonScriptSyntaxHighlighter. But this drags in several other dependencies including scijava-ui-swing, which is undesirable. The syntax highlighting layer should probably be its own layer. We need to scrutinize the modularity of the script-editor component to improve the architecture here.

Activity

  1. karlduderstadt commented on Jul 7, 2023

    @karlduderstadt
    Collaborator

    Yes, I remember worrying about this and trying to think of an alternative approach. One quick fix could be to move PythonScriptSyntaxHighlighter to the highlighters package in the script-editor. https://github.com/scijava/script-editor/tree/master/src/main/java/org/scijava/ui/swing/script/highliters

    As long as the name matches it should work and that would remove the dependency issue. But obviously that is perhaps not the most elegant solution.

  2. imagesc-bot commented on Jul 21, 2023

    @imagesc-bot

    This issue has been mentioned on Image.sc Forum. There might be relevant details there:

    https://forum.image.sc/t/python-syntax-highlighting-stopped-working-in-fiji-script-editor/83615/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions