Repository navigation
ClusterRoles and ClusterRoleBindings: metadata.name too common #2621
Description
➹ New Feature implementation request
A minor detail to fix possible nameconflict in non-namespaced resources.
Is your feature request related to a problem?
ClusterRoles and ClusterRolesBindings are not bound to any namespace. The metadata.name (manager-role and manager-rolebinding) of ClusterRoles and ClusterRolesBindings are too common and could cause nameconflicts. (happened in my cluster with another project)
Describe the solution you'd like
Change the names to securecodebox-manager-role and securecodebox-manager-rolebinding.
Describe alternatives you've considered
- A solution is to use kustomize to deploy the helm chart and patch the respective fields. However, this is overly complicated when the name can just be initialy fixed.
Additional context
Reacted by Jannik Hollenbach
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
J12934 commentedon Aug 22, 2024
Hi @DiiBBz
Thanks for opening the issue.
Yes, agreed the naming of these roles have been a oversight when initially setting up the project.
I was planning on renaming this whith the next major release (5.0.0) which we are planning to have release in a couple of month. Renaming them itself shouldn't be breaking but I would still prefer to mark this as a thing to be aware of while updating in case somebody started using the roles for something else (Which i hope they don't but with that common of a name for a cluster role its hard to rule out)
secureCodeBox#2621 Rename ClusterRole and ClusterRoleBinding
secureCodeBox#2621 Rename ClusterRole and ClusterRoleBinding
secureCodeBox#2621 Rename ClusterRole and ClusterRoleBinding
secureCodeBox#2621 Document renaming of ClusterRole/ClusterRoleBindin…
#2621 Rename ClusterRole and ClusterRoleBinding
#2621 Document renaming of ClusterRole/ClusterRoleBinding in upgradin…