← 输入框|github.com|刷新
Skip to content

Change "OSI Layer" to TCP/IP Layer #543

Closed

Description

@JohannesZahn

➹ New Feature implementation request

Is your feature request related to a problem?

The OSI Stack is not used in practice and therefore not applicable to the Findings generated by the SCB.

Describe the solution you'd like

Use the TCP/IP Stack instead as described here in RFC 1122:

  • Link
  • Internet
  • Transport
  • Application

"osi_layer" should be renamed to "communication_layer"

Describe alternatives you've considered

Instead of "tcp_ip_stack_layer" it could be called "internet_protocol_suite_layer"

Additional context

Activity

  1. changed the title [-]Change OSI Layer to ICP/TCP Stack Layer[/-] [+]Change "OSI Layer" to TCP/IP Layer[/+] on Jul 16, 2021
  2. JohannesZahn commented on Jul 20, 2021

    @JohannesZahn
    ContributorAuthor

    We decided to remove the osi_layer from the findings schema and documentation for now. It will still be generated by the parsers that currently do so. We will improve/change it once we have a good use case for it.

  3. linked a pull request that will close this issueValidate SCB Findings in Unit Tests #520on Jul 20, 2021
  4. J12934 commented on Jul 20, 2021

    @J12934
    Member

    I think this might have been closed by accident? @JohannesZahn

  5. self-assigned this
    on Jul 20, 2021
  6. JohannesZahn commented on Jul 30, 2021

    @JohannesZahn
    ContributorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions