Repository navigation
Makefile-based scanner creation throws error #749
Description
🐞 Bug report
When using make create-new-scanner NAME=something to create a new scanner (as introduced in #706), I get an error.
Describe the bug
mmaass@my-machine SecureCodeBox % make create-new-scanner NAME=openwpm
Copied template files to new directory ./scanners/openwpm
sed: 1: "./Makefile": invalid command code .As far as I can tell, all files are created from the template as planned, but the sed command to replace new-scanner with the scanner name fails.
Expected behavior
The command should run without errors and replace new-scanner with the provided name of the scanner inside the template files.
System:
Mac OS 11.6, zsh shell.
Activity
Weltraumschaf commentedon Oct 21, 2021
The problem is that sed on BSD Unix machines behaves slightly different than on GNU Linux machines: On BSD Unix the option
-irequires an argument. On Gnu Linux you can simply omit it to make an inline sed. On BSD machines it must besed -i '' ....malexmave commentedon Oct 21, 2021
I can confirm that adding the
''after the-iin the makefile makes it work correctly, but cannot test if it breaks it on Linux machines :).Weltraumschaf commentedon Oct 21, 2021
AFAIK it does not break on GNU Linux. I test it.
Fixes #749 by adding empty string for backup file in sed
Weltraumschaf commentedon Oct 21, 2021
Nope, does not work on GNU Linux. We need a platform based switch in the Makefile. The problem is that -i option of sed is not POSIX conform and not portable. Internet says: Avoid the -i option at all.
Weltraumschaf commentedon Oct 21, 2021
I fixed it. @SebieF maybe you want to look into it, I made some improvements to the make target.
Merge pull request #751 from secureCodeBox/bugfix/issue_749