← 输入框|github.com|刷新
Skip to content

make scanner-docs / hook-docs fails on macOS #754

Closed

Description

@malexmave

🐞 Bug report

Running make scanner-docs or make hook-docs fails on OS X.

Describe the bug

$ make scanner-docs
# Start in the scanners folder
cd scanners
# https://github.com/koalaman/shellcheck/wiki/SC2044
find . -type f -name Chart.yaml -print0 | while IFS= read -r -d '' chart; do
/bin/sh: -c: line 1: syntax error: unexpected end of file
make: *** [scanner-docs] Error 2
$ make hook-docs
.: ⚙ Generate Helm Docs.
# Start in the hooks folder
cd hooks
# https://github.com/koalaman/shellcheck/wiki/SC2044
find . -type f -name Chart.yaml -print0 | while IFS= read -r -d '' chart; do
/bin/sh: -c: line 1: syntax error: unexpected end of file
make: *** [hook-docs] Error 2

Adding backslashes to the ends of all relevant lines of the make command results in new issues with "unexpected token: then", and fixing that results in errors where the variables aren't set correctly, so the cd fails etc. - it seems to be fairly fundamentally broken on OS X at the moment.

Steps To Reproduce

Run the command on OS X :).

System

OS X, zsh.

Activity

  1. changed the title [-]make scanner-docs / hook-docs fails on OS X[/-] [+]make scanner-docs / hook-docs fails on MacOS[/+] on Dec 7, 2021
  2. Weltraumschaf commented on Feb 1, 2022

    @Weltraumschaf
    Member

    Root cause is that make shipped w/ macOS does not support .ONESHELL which has the effect that each line is run in its own subshell. So the initial cd into the scanners directory does not affect the find.

  3. added 11 commits that reference this issue on Feb 1, 2022
  4. 75 remaining items

  5. added 13 commits that reference this issue on Feb 16, 2022
  6. changed the title [-]make scanner-docs / hook-docs fails on MacOS[/-] [+]make scanner-docs / hook-docs fails on macOS[/+] on Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions