Repository navigation
Change host to hostname in zap parser - #1346
Merged
Merged
Conversation
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| eslint | 1 | 1 | 1.07s | ||
| ✅ SPELL | misspell | 6 | 0 | 2.47s | |
| ✅ YAML | prettier | 5 | 0 | 4.26s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
malexmave
previously requested changes
Sep 7, 2022
malexmave
left a comment
Member
There was a problem hiding this comment.
Don't forget to also update the example findings for ZAP and ZAP advanced (they are shown on the documentation site) :)
Contributor
|
This pull request includes breaking changes. Please make sure that you included the breaking changes and the steps required to upgrade in UPGRADING.md. |
the-simmon
force-pushed
the
maintenance/zap-rename-to-hostname
branch
from
October 12, 2022 09:31
4766072 to
31afea9
Compare
J12934
previously approved these changes
Oct 13, 2022
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
the-simmon
force-pushed
the
maintenance/zap-rename-to-hostname
branch
from
October 25, 2022 15:23
1da8135 to
248fe9f
Compare
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #853 partly, in particular this comment