Repository navigation
Fixed Scans being marked as Failed after the First Jobs has failed - #2205
Merged
Merged
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| golangci-lint | 1 | 1 | 5.14s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by
|
Hi, are there any updates on this PR? We are experiencing a serious issue that this PR could solve, and we would greatly appreciate it if we could proceed with it. |
Member
Author
Working on it :) The tests just need to be updated, and the fix should be in the next release. |
Ilyesbdlala
force-pushed
the
bugfix/fix-early-scan-failure
branch
2 times, most recently
from
February 9, 2024 17:01
a6f3299 to
364ce25
Compare
…fLimit BackoffLimit can be set in the values.yaml of scanners This allows that a scan is only considered as Failed if all "retries" have failed BackoffLimit is an int32; negative BackoffLimit values act like a value of 0, and non int are not allowed when the helm chart is deployed Co-authored-by: Boris Shek <boris.shek@iteratec.com> Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This fits better the definition of BackOffLimit https://kubernetes.io/docs/concepts/workloads/controllers/job/#pod-backoff-failure-policy Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Default is 3. This avoid needless retries in jest intergration tests Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…ctionality Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…e target Default is 3. This avoid needless retries in jest intergration tests Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala
force-pushed
the
bugfix/fix-early-scan-failure
branch
from
February 9, 2024 17:01
364ce25 to
50f5d26
Compare
|
J12934
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the condition for failed job to requiring exceding the specified BackoffLimit
BackoffLimit can be set in the values.yaml of scanners
This allows that a scan is only considered as Failed if all "retries" have failed
closes #238
Checklist