Repository navigation
Added backoffLimit configuration option to all scan Jobs - #244
Merged
J12934 merged 6 commits intoDec 14, 2020
Merged
Conversation
rfelber
commented
Dec 7, 2020
rfelber
marked this pull request as ready for review
December 8, 2020 13:15
J12934
reviewed
Dec 9, 2020
Comment on lines
+14
to
+16
| {{- if .Values.scannerJob.backoffLimit }} | ||
| backoffLimit: {{ .Values.scannerJob.backoffLimit }} | ||
| {{- end }} |
Member
There was a problem hiding this comment.
I'd skip the if here and directly reference the backoff limit as we have a non nil default for it.
J12934
approved these changes
Dec 14, 2020
J12934
deleted the
feature/add-backoffLimit-and-mark-failed-jobs-accordingly
branch
December 14, 2020 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testruns for the whole project.Description
Closes #238