Repository navigation
Refactor Parser-SDK and Hook-SDK to use SCB-SDK - #250
Closed
nigthknight wants to merge 9 commits into
Closed
nigthknight wants to merge 9 commits into
nigthknight wants to merge 9 commits into
Conversation
nigthknight
force-pushed
the
hash-finding
branch
3 times, most recently
from
February 8, 2021 12:40
acdb7e4 to
c2a14f4
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I noticed that the code for the uploadFile function is also used in the parser-sdk I extracted the code for `uploadFile` into scb-sdk and refactored the parser-sdk to use this function as well Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I found that the hook-sdk as well as the parser-sdk are updating the scans in the same way so I extracted the function `updateScanStatus` into the scb-sdk After moving the function there was no need to export the `severityCount` function anymore so I removed the export for this function Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
To enable us to use the scb-sdk in both parser- and hook-sdk whithout publishing the scb-sdk to npm. Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
force-pushed
the
hash-finding
branch
from
February 8, 2021 13:28
c2a14f4 to
12c5659
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
force-pushed
the
hash-finding
branch
from
February 10, 2021 11:20
dfea192 to
b329411
Compare
I introduced a new Build step building the basic scb-sdk before building parser- and hook-sdk Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Member
Author
|
I'm closing this PR because refactoring the SDKs is not a priority at the moment and the branch is very outdated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If applied this PR will
Checklist
npm testruns for the whole project.Description