Repository navigation
Conversation
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4b936d9 to
6265550
Compare
|
|
Hi @mvanhorn, The suggested changes look good so far and it is probably a good idea in general to have a return statement when there are no jobs available. |
|
Thanks for reviewing. I agree that the current test does not verify the issue described. I wasn't able to reproduce the failure reliably in my setup, so I can't claim this test demonstrates that the change fixes the original problem. The return statement is still intended to handle the no-jobs case safely, but I'll add more context or a targeted regression test if I can identify a reproducible failure path. |
|
Hi, Thank you for the fast respond:) |
Refs secureCodeBox#3139 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
6265550 to
12fc75f
Compare
|
Description
Change
checkIfAllJobsCompletedso that a list containing no Jobs is explicitly incomplete; completion must require at least one observed Job and successful status for every observed Job. Keep the existing precedence in which anyBackoffLimitExceededJob reports failure and any non-succeeded Job reports incomplete, so all three production callers (the scanner, parser, and hook reconciliation paths) remain conservative during cache-observation gaps. Extend the existing table of focused helper tests with the empty-list case, while retaining coverage for all-succeeded, mixed/incomplete, and failed lists.The scan reconciler decides whether scanner, parser, and hook Jobs have finished through
checkIfAllJobsCompleted. That helper initializes its aggregate result as completed, so an empty Job list is interpreted as successful even though no Job has reported success. During the short interval in which the controller cache has not yet observed a newly created scanner Job, this can advance the Scan toScanCompletedand start the parser before the scanner uploads its raw result, producing an intermittent MinIONoSuchKeyerror. The maintainer reproduced the rare behavior and identified this helper as the relevant decision point.Refs #3139
Checklist