← 输入框|github.com|刷新
Skip to content

#3784 Document Unused Tokens - #3836

Merged
Reet00 merged 3 commits into
secureCodeBox:mainfrom
Weltraumschaf:3784_document-tokens
Oct 6, 2026
Merged

#3784 Document Unused Tokens#3836
Reet00 merged 3 commits into
secureCodeBox:mainfrom
Weltraumschaf:3784_document-tokens

Conversation

@Weltraumschaf

@Weltraumschaf Weltraumschaf commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

So we have the names somewhere before deleting it. Just in case we need to restore them.

@Weltraumschaf Weltraumschaf self-assigned this Sep 15, 2026
@netlify

netlify Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docs-securecodebox ready!

Name Link
🔨 Latest commit 47e55d8
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/6aad0b09001ffa000834d2c7
😎 Deploy Preview https://deploy-preview-3836--docs-securecodebox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Weltraumschaf Weltraumschaf added the documentation Improvements or additions to documentation label Sep 15, 2026
@Weltraumschaf Weltraumschaf moved this from Triage to To Review in secureCodeBox Sep 15, 2026
J12934
J12934 previously requested changes Sep 15, 2026
View reviewed changes
Comment thread documentation/docs/contributing/project-management.md Resolved
Comment thread documentation/docs/contributing/project-management.md Resolved
Comment thread documentation/docs/contributing/project-management.md Resolved
Comment thread documentation/docs/contributing/project-management.md Resolved
@J12934

J12934 commented Sep 15, 2026

Copy link
Copy Markdown
Member

Sorry had a look over the changed and didn't read the PR description, but don't really get what we have by basically documenting something that we don't understand what it was used for.

Either it breaks and we have to investigate what broke or they are unused and everything is fine.
Not sure what benefits we get, having this in the repo

@Weltraumschaf
secureCodeBox#3784 Document Unused Tokens
167e972 
So we have the names somewhere before deleting it. Just in case we
need to restore them.

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#3784 Deleted Tokens From Project Settings
71dc95f 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#3784 Document Tokens for defectdojo-client-java Repo
47e55d8 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 18, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Weltraumschaf

Weltraumschaf commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

Sorry had a look over the changed and didn't read the PR description, but don't really get what we have by basically documenting something that we don't understand what it was used for.

Either it breaks and we have to investigate what broke or they are unused and everything is fine. Not sure what benefits we get, having this in the repo

If hold the names in the first commit, so that I have I list which ones to delete, too 😂

I went through all not archived repos. All of them removed and also documented the ones used in defectdojo-client-java.

Stumbled upon this repo: https://github.com/secureCodeBox/swagger-petstore-openshift Can we archive it?

@Weltraumschaf

Weltraumschaf commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

Stumbled upon this repo: https://github.com/secureCodeBox/swagger-petstore-openshift Can we archive it?

Archived.

Reet00
Reet00 approved these changes Oct 6, 2026
View reviewed changes

@Reet00 Reet00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Reet00
Reet00 dismissed J12934’s stale review October 6, 2026 11:36

Changes have been addressed

@Reet00
Reet00 merged commit 4334b13 into secureCodeBox:main Oct 6, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Reet00 Reet00 Reet00 approved these changes
@J12934 J12934 Awaiting requested review from J12934

Assignees

@Weltraumschaf Weltraumschaf

Labels

documentation Improvements or additions to documentation

Projects

secureCodeBox
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Weltraumschaf @J12934 @Reet00