← 输入框|github.com|刷新
Skip to content

Improve install/uninstall script to respect namespaces - #425

Merged
rfelber merged 8 commits into
mainfrom
feature/improve-install-script
Jul 6, 2021
Merged

rfelber merged 8 commits into
mainfrom
feature/improve-install-script

Conversation

@rfelber

@rfelber rfelber commented May 17, 2021

Copy link
Copy Markdown
Member

Description

This PR if applied improves the bin/install.sh and bin/uninstall.sh scripts to respect namespaces. This is helpful for different installation scenarios.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
@rfelber rfelber self-assigned this May 17, 2021
@rfelber
rfelber enabled auto-merge May 17, 2021 15:42
@nigthknight
nigthknight requested a review from Weltraumschaf May 22, 2021 14:42
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/uninstall.sh Resolved
Comment thread bin/uninstall.sh Resolved
Comment thread bin/uninstall.sh Resolved
Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
@rfelber rfelber added this to the v3.0.0 milestone Jun 16, 2021
@rfelber
rfelber requested a review from Weltraumschaf June 16, 2021 20:29
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
Comment thread bin/install.sh Resolved
@rfelber rfelber modified the milestones: v3.0.0, 2.9.0 Jun 18, 2021
rfelber added 2 commits July 2, 2021 21:51
Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
@rfelber
rfelber requested a review from Weltraumschaf July 2, 2021 19:55
Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>

@Weltraumschaf Weltraumschaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelber
rfelber merged commit 450e053 into main Jul 6, 2021
@rfelber
rfelber deleted the feature/improve-install-script branch July 6, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants