← 输入框|github.com|刷新
Skip to content

Added a Typo3 Scanner (closes #568) - #608

Merged
J12934 merged 45 commits into
mainfrom
typo3_scanner
Aug 27, 2021
Merged

J12934 merged 45 commits into
mainfrom
typo3_scanner

Conversation

@Ilyesbdlala

@Ilyesbdlala Ilyesbdlala commented Aug 24, 2021 •

Copy link
Copy Markdown
Member

Description

Added a new Scannner that that scans websites using TYPO3 content management system: typo3scan. It detects core vulnerabilities and scans for installed extensions. From these extensions, the vulnerable ones can be identified.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@Ilyesbdlala Ilyesbdlala added the scanner Implement or update a security scanner label Aug 24, 2021
@Ilyesbdlala Ilyesbdlala self-assigned this Aug 24, 2021
J12934 and others added 15 commits August 24, 2021 11:07
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This cas caused the configmaps to contain a empty list of scripts as the scipts weren't included in the chart anymore :(

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
SebieF and others added 7 commits August 24, 2021 13:09
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Co-authored-by: Sebastian Franz <32578476+SebieF@users.noreply.github.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Sorry.

Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Ilyesbdlala requested a review from SebieF August 25, 2021 11:32
Comment thread scanners/typo3scan/scanner/Dockerfile Resolved
Comment thread scanners/typo3scan/.helm-docs.gotmpl Resolved
Ilyesbdlala and others added 3 commits August 25, 2021 17:03
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>

Co-authored-by: Sebastian Franz <32578476+SebieF@users.noreply.github.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>

Co-authored-by: Sebastian Franz <32578476+SebieF@users.noreply.github.com>
Comment thread scanners/typo3scan/examples/scan.yaml Resolved
Comment thread scanners/typo3scan/parser/parser.js Resolved
Comment thread scanners/typo3scan/parser/parser.js Resolved
Comment thread scanners/typo3scan/examples/scan.yaml Resolved
Comment thread scanners/typo3scan/scanner/Dockerfile Resolved
J12934 and others added 5 commits August 27, 2021 14:13
Co-authored-by: Ilyes Bendlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
- Didn't need the dependencies
- Fixed issue of automatically parsed json results

Co-authored-by: Ilyes Bendlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
- Removing wrapper script, not needed when workdir is set to scb dir
- Chowning files while copying

Co-authored-by: Ilyes Bendlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Co-authored-by: Ilyes Bendlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Co-authored-by: Ilyes Bendlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934
J12934 previously approved these changes Aug 27, 2021
@J12934
J12934 dismissed SebieF’s stale review August 27, 2021 12:18

Outdated :)

@Ilyesbdlala Ilyesbdlala removed a link to an issue Aug 27, 2021
11 tasks done
@J12934

J12934 commented Aug 27, 2021

Copy link
Copy Markdown
Member

merging now, some small followup tasks have been added to the typo3 issue

@J12934
J12934 enabled auto-merge August 27, 2021 12:19
@J12934
J12934 disabled auto-merge August 27, 2021 12:28
@J12934
J12934 merged commit a6e3aa4 into main Aug 27, 2021
@J12934
J12934 deleted the typo3_scanner branch August 27, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scanner Implement or update a security scanner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants