Repository navigation
Implement init container support (ADR-0009) - #724
Merged
Merged
Conversation
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Member
Author
|
I just updated the CRDs in the right place for Helm as well. The way I understand it, the files in operator/crds should be identical to those in operator/config/crd/bases. However, it seems like they weren't identical before I regenerated the CRDs after including the new initContainer element in them (the diffs in both locations are different, while the new version of both files are identical, so the versions before the change weren't identical). Since they are identical now, I hope that this is fine, but in case people want to check what changed compared to the previous "production" versions, see f0973e8. |
J12934
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements ADR-0009 by exposing the initContainers API in the scantypes. It thus closes #707.
Description
ScanTypes now expose another configuration option,
initContainers, which allows you to specify a container (or set of containers) that should run before the scan container. Use this to download files onto the scanner or perform other actions in preparation for the scan. It uses the built-in functionality of Kubernetes and does not require any SCB-specific knowledge.For testing, here's an example application of an nmap scan that scans a set of websites that is downloaded from the web using an initContainer.
I will update the documentation to provide example use cases and create a PR on the relevant repo next.
Checklist
npm testruns for the whole project.