Repository navigation
Add missing providers to the statically loaded fallback - #1377
Open
555aaditya wants to merge 3 commits into
Open
555aaditya wants to merge 3 commits into
555aaditya wants to merge 3 commits into
Conversation
The fallback for issue sqlancer#799 builds its provider list inline in checkForIssue799. Move it into getStaticallyLoadedProviders() so that it can be inspected and tested. Behavior is unchanged.
The fallback for issue sqlancer#799 lists the providers known on June 7, 2023, so Cloudberry, DataFusion, and VoltDB cannot be selected when ServiceLoader finds no providers. Add them, and drop the outdated date from the warning message.
Compare the providers of the issue sqlancer#799 fallback with the providers that the @autoservice annotation registers, so that a new provider cannot be forgotten in the fallback again. Providers defined by tests are ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #799.
When
ServiceLoaderfinds no providers,Main.checkForIssue799falls back to a hard-coded list of providers. That list is from June 2023 and is missing Cloudberry, DataFusion, and VoltDB, so these three cannot be selected in that situation.This PR:
Main.getStaticallyLoadedProviders()(no behavior change),CloudberryProvider,DataFusionProvider, andVoltDBProvider, and drops the outdated date from the warning,TestStaticProviderList, which compares the fallback with the providers registered via@AutoService, so that a new provider cannot be forgotten again. Providers defined intest/(VirtualDBProvider) are ignored.It does not address the root cause of #799 (the annotation processor not running in some IDE setups, or on some JVMs), which I could not reproduce, so I left the issue open.
Verified on macOS (arm64), OpenJDK 11.0.33, Maven 3.10.1:
mvn -B verify -DskipTests=true: BUILD SUCCESS on each of the three commits.python3 src/check_names.py: exit 0.mvn -Djacoco.skip=true '-Dtest=!sqlancer.dbms.**,!sqlancer.qpg.**' test: 126 tests, 0 failures, 3 skipped (125 tests, same result, onorigin/main).CloudberryProvider,DataFusionProvider, andVoltDBProvider; it passes with the new list.Not verified: the empty-
ServiceLoaderscenario itself (I ran the fallback list through the test only); the DBMS smoke tests, which this change does not touch.@mrigger