← 输入框|github.com|刷新
Skip to content

Check the class names of the Hive and Spark providers - #1379

Open
555aaditya wants to merge 1 commit into
sqlancer:mainfrom
555aaditya:fix/check-names-hive-spark
Open

555aaditya wants to merge 1 commit into
sqlancer:mainfrom
555aaditya:fix/check-names-hive-spark

Conversation

@555aaditya

Copy link
Copy Markdown

src/check_names.py checks that every class in a DBMS package starts with the name of the DBMS (CONTRIBUTING.md, "Naming Conventions"). The Hive and Spark packages were never added to it, so a misnamed class in src/sqlancer/hive or src/sqlancer/spark would not be reported. This PR adds both. Their current classes all follow the convention, so the script still passes.

Checked on macOS, Python 3.12:

  • python3 src/check_names.py on the unchanged tree: prints checking database pass: Hive and ... Spark, exit 0.
  • With a temporary, uncommitted Wrong.java in each of the two packages: with this change the script reports The class name of Wrong.java does not start with Hive and exits with 255; without the change (the script from main) it exits 0 and reports nothing.

I did not run Maven for this PR, because it only changes a Python script that CI runs in the misc job.

@mrigger

check_names.py verifies that every class of a DBMS starts with the name of the DBMS, but the Hive and Spark packages were never added to it, so a class with a wrong name would not be reported for them. Both packages already follow the convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant