Repository navigation
Check the class names of the Hive and Spark providers - #1379
Open
555aaditya wants to merge 1 commit into
Open
555aaditya wants to merge 1 commit into
555aaditya wants to merge 1 commit into
Conversation
check_names.py verifies that every class of a DBMS starts with the name of the DBMS, but the Hive and Spark packages were never added to it, so a class with a wrong name would not be reported for them. Both packages already follow the convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/check_names.pychecks that every class in a DBMS package starts with the name of the DBMS (CONTRIBUTING.md, "Naming Conventions"). The Hive and Spark packages were never added to it, so a misnamed class insrc/sqlancer/hiveorsrc/sqlancer/sparkwould not be reported. This PR adds both. Their current classes all follow the convention, so the script still passes.Checked on macOS, Python 3.12:
python3 src/check_names.pyon the unchanged tree: printschecking database pass: Hiveand... Spark, exit 0.Wrong.javain each of the two packages: with this change the script reportsThe class name of Wrong.java does not start with Hiveand exits with 255; without the change (the script frommain) it exits 0 and reports nothing.I did not run Maven for this PR, because it only changes a Python script that CI runs in the
miscjob.@mrigger