← 输入框|github.com|刷新
Skip to content

add databend bugs - #646

Merged
mrigger merged 2 commits into
sqlancer:masterfrom
hanyisong:master
Dec 16, 2022
Merged

mrigger merged 2 commits into
sqlancer:masterfrom
hanyisong:master

Conversation

@hanyisong

Copy link
Copy Markdown
Contributor

No description provided.

hanyisong and others added 2 commits December 16, 2022 20:37
errors.add("assertion failed: offset + length <= self.length");
}
errors.add("validity's length must be equal"); // bug
// errors.add("validity's length must be equal"); // bug

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can remove this comment instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error was triggered with a small probability before, I forgot to leave a log.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I see. Then let's leave the comment in for now.

@mrigger

mrigger commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

By the way, before reporting bugs, it is useful to reduce the bug-inducing test case to a minimal version that still triggers the bug (e.g., by repeatedly removing statements as long as the error/incorrect result is triggered). This also helps in identifying what potential features trigger the bug, whose generation can be disabled until the bug is fixed.

@mrigger

mrigger commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

@kshehata recently added experimental support for test case reduction (see #624). Perhaps you could check whether this is useful for your efforts in testing Databend?

@mrigger
mrigger merged commit a3357c1 into sqlancer:master Dec 16, 2022
@hanyisong

Copy link
Copy Markdown
Contributor Author

Thanks for the advice, I was too anxious.

albertZhangTJ pushed a commit to albertZhangTJ/sqlancer-lancerfuzz that referenced this pull request Dec 19, 2022
Signed-off-by: Yisong Han <yisong8686@gmail.com>

Signed-off-by: Yisong Han <yisong8686@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants