Repository navigation
Add query logging for MySQL - #793
arvind-murty wants to merge 1 commit into
Conversation
Signed-off-by: Arvind Murty <arvindmurty@arvinds-mbp.lan>
|
This does not actually fix anything. The log files are overwritten when an erroring query occurs (which I assume is intended behavior), and MySQL errors far more frequently than other DBMS's. |
During normal execution, no errors should appear unless SQLancer has found a bug. Perhaps it is related to https://github.com/sqlancer/sqlancer#i-am-running-sqlancer-on-the-latest-version-of-a-supported-dbms-is-it-expected-that-sqlancer-prints-many-assertionerrors? |
Yes, most likely, since I am running MySQL 8.0.33. I was also thinking about the logging behavior and I'm not sure if it's intended anymore. Essentially, if I exit the execution (with If instead an AssertionError is thrown, then there are two log files produced ( I only found this behavior on MySQL because the other DBMS's I tested (DuckDB and SQLite) never errored, which is why I thought MySQL had a logging error. |
|
Yes, that sounds like a bug. Thanks for mentioning it! Do you want to open an issue copying the text? If not, I can create an issue. We should also at some point in time update the MySQL implementation (cc @Zhenglin-Li and @bajinsheng). |
I have created the issue (#794). |
ok, will have a look at it. |
This PR adds query logging for MySQL. I simply copied from
SQLite3TLPWhereOracle.java, as modified by PR #648.