← 输入框|github.com|刷新
Skip to content

💥 Checks should be able to fail in release scripts (remove set +e) #103

Closed

Description

@NickLarsenNZ

Note

This came out of the 25.3.0 Release Retro.

Currently, failures are ignored during checks.

Examples

# sanity checks before we start: folder, branches etc.
# deactivate -e so that piped commands can be used
set +e
checks
set -e

# sanity checks before we start: folder, branches etc.
# deactivate -e so that piped commands can be used
set +e
check_operators
set -e

set +e
check_products
set -e

# sanity checks before we start: folder, branches etc.
# deactivate -e so that piped commands can be used
set +e
checks
set -e

Activity

  1. added
    release-retro/25.3.0Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0
    on Apr 24, 2025
  2. changed the title [-]💥 Checks should fail in release scripts (remove `set +e`)[/-] [+]💥 Checks should be able to fail in release scripts (remove `set +e`)[/+] on Apr 24, 2025
  3. added theissue type on May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    release-retro/25.3.0Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions