← 输入框|github.com|刷新
Skip to content

500 errors are not handled properly #358

Closed

Description

@shinchris

When a synchronous publish call times out on the server side, TSC returns an error about a failure to parse the response. It should return a proper error that directs clients to use the async publish method.

Activity

  1. self-assigned this
    on Nov 13, 2018
  2. shinchris commented on Nov 14, 2018

    @shinchris
    ContributorAuthor

    The issue is for all 500 errors in general. Since 500 errors do not have xml response, TSC throws this exception:

    File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/tableauserverclient/server/endpoint/exceptions.py", line 18, in from_response
        error_response = cls(parsed_response.find('t:error', namespaces=ns).get('code', ''),
    AttributeError: 'NoneType' object has no attribute 'get'
    

    It's not clear from this error that there was a 500 error.

  3. changed the title [-]504 error during publishing should be handled properly[/-] [+]500 errors are not handled properly[/+] on Nov 14, 2018
  4. irwando commented on Jul 25, 2019

    @irwando

    Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions