← 输入框|github.com|刷新
Skip to content

Sync tasks loose contextvars #482

Closed

Description

@slafs

I've run into this when using structlog.
We've added a middleware where we add a bunch of contextvars with structlog.contextvars.bind_contextvars
and noticed that the logs within the sync tasks are missing them.
Async tasks are fine.

I have PR incoming with an attempt to fix that and a test that hopefully shows better what I mean 😅.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions