Repository navigation
api: expect token revocation in user password tests - #10
Merged
Merged
Conversation
UpdatePassword revokes the user's tokens since 2afb1d6, but two success cases in user_test.go did not expect the call, so TestUserServiceSuite failed in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go CI has failed on master since 2afb1d6. UpdatePassword now calls RevokeUserTokens, but the "Self With Correct Current Password" and "Other User As Admin" cases in user_test.go did not expect it, so the mock failed TestUserServiceSuite.
Adds the missing RevokeUserTokens expectations to both cases. No mock or interface changes:
make interfacesregenerates them with no diff.go test ./...in apps/api passes.