Repository navigation
api | web: show the team icon in place of the logo inside projects - #12
Merged
Merged
Conversation
- Inside a project the logo already links to the team page, so it now shows the team's icon there. Everywhere else it still shows the Unbind logo. The project route prefetches the team so the icon is ready when the page loads. - Raise the team icon size limit from 50 KB to 512 KB in the API, the web upload checks and the docs. - Pre-commit now installs web and docs packages when node_modules is missing. Before this, the prettier and eslint hooks failed in fresh worktrees because they couldn't find their plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside a project, the logo at the start of the breadcrumb already links to the team page. Because the team isn't shown in the breadcrumb there, the logo now shows the team's icon. Everywhere else, including the team page, it still shows the Unbind logo.
LogoLinkshows the team icon on project routes. It shows a skeleton while the team loads and falls back to the Unbind logo if the team can't be loaded.node_modulesis missing. Before this, the prettier and eslint hooks failed in fresh worktrees because they couldn't find their plugins (for exampleprettier-plugin-tailwindcss).Testing
TestParseIconRejectscase for the new 512 KB limit.