Repository navigation
web: stop a pending close from clearing a reopened deployment panel - #13
Merged
Merged
Conversation
Closing the panel starts a timer that clears the current deployment once the drawer animation ends. Opening a deployment did not cancel that timer, so reopening the panel shortly after closing it let the timer fire and blank the deployment, and the panel showed the "Unknown" state. The timer is now cleared in the effect cleanup, so selecting a deployment cancels any pending clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UNB-370: https://ricrac.app/unbind/issue/UNB-370
Sometimes clicking a deployment card opened the panel with the "Unknown" state.
Cause
drawerAnimationMs).Fix
deployment-panel-provider.tsxnow returns a cleanup function that clears the timer. Selecting a deployment cancels any pending clear.useRefthat used to hold the timeout, so the effect is shorter.