Repository navigation
web: enlarge team icons in the logo link, breadcrumbs and dropdowns - #15
Merged
Merged
Conversation
The icons get slightly bigger without making the buttons or rows any taller. Negative vertical margins absorb the extra size, and the existing left offsets and gaps stay the same, so the spacing around the icons doesn't shift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the team icons a little bigger without making the buttons or rows any taller, and without moving anything around the icons.
size-6tosize-6.5. The fallbackLogostays atsize-6.size-4.5tosize-5. A new-my-pxkeeps the trigger the same height.SheetItemandDropdownItemtake a new optionalclassNameIconprop, which is merged into the icon's classes withcn. The breadcrumb passessize-5.5to sheet items (mobile) andsize-5to dropdown items (desktop). The existing-my-1keeps the rows the same height.The left offsets (
-ml-1/-ml-0.5) and the gaps between icon and text are unchanged, so the space to the left of each icon and between the icon and its label stays the same.