Repository navigation
web: sort metrics chart tooltip and legend by value - #19
Merged
Merged
Conversation
With many services the tooltip listed series in API order, so the largest consumers were hard to spot. - Tooltip rows are now sorted by their value at the hovered timestamp, largest first. ChartTooltipContent ignored Recharts' itemSorter, so it now applies the sorter to the payload itself. - Legend entries are sorted by their average value over the window, largest first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves UNB-458.
The metrics chart tooltip and legend listed series in the order the API returned them. With many services it was hard to see which ones used the most.
ChartTooltipContentignored Recharts'itemSorterprop, so it now sorts the payload withitemSorteritself.MetricsChartpasses a descending-by-value sorter.The legend still uses the series config, so colours and the click-to-isolate filter stay the same.