Repository navigation
api | web | docs: share a github connection with many teams or all teams - #24
Merged
Merged
Conversation
… teams Until now a GitHub App connection belonged to a single team. Every team that built from the same GitHub account had to install its own app there. - Replace the single team_id on github apps with a many-to-many teams relation and a shared_with_all_teams flag. The flag also covers teams created later. A migration moves existing team links into the new table. - Repo access is still limited by what the installation can reach. - The sharing picker now has "Only me" and "All teams" in one group and a multi-select list of teams below. Choosing "Only me" or "All teams" clears the team selection. Team icons are shown, and selected teams get a success-colored border and tick. - Update the docs on deploying from GitHub and on team permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves UNB-415.
Right now a GitHub App connection belongs to one team. Every team that builds from the same GitHub account has to install its own app there, and the account owner has to approve each one. With this change, one installation per GitHub account can be shared with several teams, or with all teams. New teams can then build without another approval.
Changes
team_idongithub_appswith a many-to-manyteamsrelation (team_github_apps) and ashared_with_all_teamsflag. The flag also covers teams created later. A migration moves existing team links into the new table.Testing
github_test.go) and the repository tests (github_app_test.go) for multi-team and all-teams sharing.