Repository navigation
web: drop team icon borders and widen breadcrumb dropdowns - #27
Merged
Merged
Conversation
- Team icons no longer have a border. Placeholder icons without an image now use bg-border, so they can use the same sizes as regular icons. - Breadcrumb triggers and dropdown items no longer pass custom icon size overrides. The logo link team icon now matches the logo at size-6. - Breadcrumb dropdowns are 16rem wide on sm and up, capped at the available width. - The breadcrumb trigger gap goes from gap-2 to gap-1.5, and the chevrons move from -ml-1 to -ml-0.5 to keep the spacing even.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Team icons no longer have a border. Without it, they can use the same sizes as regular icons instead of custom overrides.
bg-borderinstead ofbg-card.classNameIconoverride, so team icons use the default icon sizes. The trigger icon is nowsize-4.5. The team icon in the logo link (and its loading placeholder) goes fromsize-6.5tosize-6, the same size as the logo.inset-0, since there is no border left to inset it inside.sm:w-[min(16rem,var(--available-width))], so they are wider on sm and up but never wider than the available space.gap-2togap-1.5. The single and double chevrons go from-ml-1to-ml-0.5so the spacing stays even.