Repository navigation
web: match network exception search by words - #30
Merged
Merged
Conversation
The service pickers used the default fuzzy filter over the service id and path, so letters spread across a path matched and word order mattered. Searching natricon listed Natrium services first and natrium server found nothing. Every word now has to appear in the name or path, in any order, and name matches come first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The source and target pickers on System > Settings > Network used cmdk's default filter. It fuzzy-matches the search against the service id plus its team / project / environment path, letter by letter and in order:
What changed
The pickers filter themselves with
searchItems:Unit tests cover these searches.
Follow-up to UNB-384.