Repository navigation
web: size the search clear button explicitly to fix mobile Safari - #35
Merged
Merged
Conversation
The clear button took its size from the input height through aspect-square and w-auto, and mobile Safari did not render it correctly. It now uses a fixed size and is centered vertically. Callers can override the size, and the search and sort toolbar does so to match its shorter input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search input's clear (X) button got its size from the input height via
aspect-square h-full w-auto. Mobile Safari didn't render it correctly, though the other input X icons looked fine.size-8.5and is centered vertically in its container (items-center). It no longer depends on the aspect ratio.SearchInputtakes a newclassNameClearButtonprop so callers can change the button size.SearchSortToolbarsets the button tosize-7.5to fit its shorterpy-1.5input.