Repository navigation
web: stop cards dragging from overlays and fix drop placeholder pulse - #38
Merged
Merged
Conversation
- Panels and dialogs that a card opens are portaled out of the card, but React still bubbles their events up to it. That let presses inside an overlay pick up and reorder cards in the background. The sensors now only start a drag when the press lands on the card itself. - The opacity transition was always on, so the dashed placeholder faded in and out on drop. It now only runs while a card is deleting. - On service cards the shadow sits on a wrapper around the card and its volumes. The volumes were covering the shadow, so some lifted cards looked like they had none. Lifted cards also get a larger shadow, shadow-xl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
card-sorting.ts).shadow-xlinstead ofshadow-lg, so they look more clearly lifted.