Repository navigation
web: add a card height variant to no-items cards with buttons - #39
Merged
Merged
Conversation
No-items cards now have a cardHeight variant, the same way buttons have variants. md (min-h-38) is the default and lg (min-h-44) is for cards that hold a button. The cards that use lg are the project and service no-search-match cards, the no active deployment card, and the no-logs card. The no-logs card used to set its own min-h-42.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoItemsCardnow has acardHeightvariant built withcva, the same wayButtonhandles its variants. Cards that hold a button now share the same taller height.md(min-h-38) is the default, so cards that don't passcardHeightlook the same as before.lg(min-h-44) is for cards that contain a button. These cards now use it:project-card-list.tsx)service-card-list.tsx)deployments.tsx)min-h-42throughclassNameand now useslginstead.classNameis still passed through and merged with the variant classes.