Repository navigation
web: stop card drags selecting text and dragging volume links on iOS - #40
Merged
Merged
Conversation
- While a card is being dragged, text selection is turned off across the whole page, so touch drags no longer select the text they pass over. - Volume lines inside sortable service cards stop the browser's native link drag and the iOS long-press callout, both of which cancelled the reorder drag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS, dragging a project, service or service group card could select the text under the finger. On service cards it could also start a native link drag from a volume line, which cancelled the reorder.
globals.cssturnsuser-selectoff across the page whenever an element hasdata-drag-source. Touch drags no longer highlight the text they pass over. This applies to all sortable cards.ServiceCardnow passesisSortabletoVolumeUsageLine. When it's set, the volume link getsdraggable={false}to stop the browser's own link drag, and-webkit-touch-callout: noneto stop the iOS long-press callout. Both of these used to cancel the reorder drag. Volume lines outside sortable cards work as before.