Repository navigation
[connectors] NATS: use async-nats 0.51.0 - #7696
Conversation
swanandx
left a comment
There was a problem hiding this comment.
i don't understand NATS, so skimmed through this and it LGTM!
thanks!
| tokio-postgres-rustls = { version = "0.14.0", default-features = false, features = ["aws-lc-rs"] } | ||
| # Pulled in by async-nats for ws:// server URLs. Its default hashes the | ||
| # websocket handshake with sha1_smol; the feature keeps it on aws-lc-rs. | ||
| tokio-websockets = { version = "0.13.3", default-features = false, features = ["aws_lc_rs"] } |
There was a problem hiding this comment.
maybe in comment we can add keep this pinned / in sync with version that async-nates use?
There was a problem hiding this comment.
Done in 96fd8f1: the comment now says to keep the version in sync with async-nats's, and why.
The release fixes spurious MissingHeartbeat errors while messages are
buffered, pull consumers hot-looping on 409 Exceeded MaxRequest*, and
KV hangs.
Two changes reach the connector. The library now names a recreated
ordered consumer `{name}_{n}` and deletes the one it replaces, so the
cleanup on pause, disconnect, replay end and the delayed recheck lists
the stream's consumers and deletes every one descending from the name
the connector chose. Before, it deleted a name the library had already
removed and the live consumer leaked until the inactive threshold.
The publish path gains a MaxPayloadExceeded error kind, classified as
permanent. OrderedConfig limits (max_batch, max_bytes, max_expires)
now reach the server where the old library dropped them.
tokio-websockets 0.13 no longer takes aws-lc-rs from async-nats and
hashes the websocket handshake with sha1_smol. A direct dependency
forwards its aws_lc_rs feature so every hash stays on aws-lc.
Tested with the NATS engine suite (70 cases) against nats-server
2.15.2, including a new case that leaked a consumer before the fix.
Closes #7695
Signed-off-by: Xavier Bestel <xavier.bestel@feldera.com>
|
CI failure analysis for run 41094581079: not this PR's fault — fairly confident.
This PR only touches the NATS connector ( Likely cause: Filed as #7748 with the full trace and suspected fix location. Next step: re-queueing should pass — this failure isn't reachable from your changes. |
|
Verdict: infrastructure, not this PR. High confidence.
This PR only touches the NATS input connector ( This matches the recurring "shared Next step: safe to re-queue; no fix needed on this branch. |
Merge queue failure: not this PR's faultVerdict: pre-existing bug on
The test drives a mocked Kafka broker through an outage/abort/replay cycle; the commit loop reports success but the replay spool isn't fully drained. No existing issue covered it, so I filed #7760 with the evidence and assigned it to the commit's author. Next step: re-queueing should pass once #7760 is fixed — this isn't something to change in this PR. |
Linked Issue
Closes #7695
Describe Manual Test Plan
Ran the NATS engine suite against a local nats-server 2.15.2:
70 cases pass. The new case
library_recreated_consumer_is_deleted_on_pausefails on the plain version bump (the connector deletes a name the library already replaced and the recreated consumer stays on the server) and passes with the cleanup change. Clippy on the connector crates is clean.What changed
server_2_14feature that upstream now ships by default.{name}_{n}and deletes the one it replaces. Consumer cleanup now lists the stream's consumers and deletes every one descending from the name the connector chose, on pause, disconnect, replay end and the delayed recheck.MaxPayloadExceededpublish error kind, classified as permanent.aws_lc_rsfeature so the hash stays on aws-lc.Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes
None in configuration. One behaviour change: the
max_batch,max_bytesandmax_expiryconsumer settings now reach the server, where the old library dropped them on creation. A pipeline that set a very smallmax_batchwill see it enforced after the upgrade.