← 输入框|github.com|刷新
Skip to content

[profiler] Remove support for legacy profiles produced pre 0.244 (Feb 2026) - #7756

Merged
mihaibudiu merged 1 commit into
mainfrom
issue7198
Nov 1, 2026
Merged

mihaibudiu merged 1 commit into
mainfrom
issue7198

Conversation

@mihaibudiu

Copy link
Copy Markdown
Contributor

Linked Issue

Fixes #7198

That code is hard to read and maintain.

Comment thread js-packages/profiler-lib/src/profile.ts Resolved
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

What I ran

Check Result
profiler-lib: tsc --noEmit pass
profiler-lib: vitest --run 323 pass, 2 fail in viewport.test.ts. These 2 also fail on the base commit, so this PR did not cause them.
profiler-layout: full vitest --run (browser, component and unit projects) 20 files, 207 tests pass
Probe: legacy-format JSON passed to CircuitProfile.fromJson throws TypeError: data is not iterable (see inline comment)

Gates

  • missing (medium), breaking change / docs: The profiler in the web console and in profiler-app can no longer open support bundles from pipelines older than v0.244. Users on older releases still send these bundles. Add an entry under "Unreleased" in docs.feldera.com/docs/changelog.md.
  • missing (medium), actionable errors / tests: No test covers the path the PR introduces: a legacy profile should be rejected with a clear message. Add one together with the fix in the inline comment.
  • missing (low → skip): No test covers a new-format profile without the metrics field. It is now handled by json.metrics ?? [] and it used to depend on a heuristic. A quick regression test would be cheap.

Besides these, the removal and the migration of the tests to the new metric names look correct.

… 26)

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu
mihaibudiu added this pull request to the merge queue Oct 31, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 31, 2026
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

Verdict: not this PR's fault (merge-queue drop was collateral). High confidence — the diff here only touches js-packages/profiler-lib/Svelte components; nothing in DBSP, storage, or the Python test suite.

The only real failure was in Integration Tests / Runtime Integration Tests (arm64):

This test shares a fixed cache prefix across CI runs for its checkpoint fixture, and has a history of cross-run races on that shared state (#7136, #7572). The error here comes from a storage-corruption guard that fires exactly on a torn/partial state of that shared cache — consistent with another run touching the same prefix concurrently, not with anything this PR changed.

Filed as #7763 with the evidence and a race hypothesis.

Next step: re-queueing should pass; this PR's own changes aren't implicated.

@mihaibudiu
mihaibudiu added this pull request to the merge queue Oct 31, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 31, 2026
@mihaibudiu
mihaibudiu added this pull request to the merge queue Oct 31, 2026
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

Verdict: not this PR's fault. High confidence — the diff here only touches js-packages/profiler-lib/profiler-layout Svelte/TS files; nothing in the Kafka connector.

Failing job: Adapter Tests / Test Adapters (arm64)

thread 'transport::kafka::ft::output::tests::an_outage_aborts_and_replays_the_transaction' panicked at crates/connectors/src/transport/kafka/ft/output/tests.rs:260:5:
assertion `left == right` failed: the spool must be released at commit
  left: 190
 right: 0

This is a known pre-existing bug introduced on main by 6ad915e99 ("[connectors] Recover Kafka output transactions through broker outages", 2026-10-28), already tracked in #7760. It previously dropped PR #7696 from the queue the same way; I've added this run as a repeat occurrence there.

Next step: re-queueing should pass; this is unrelated to this PR's changes.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 31, 2026
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

Verdict: not this PR's fault (pre-existing flake on main)

This PR only touches profiler JS/TS files (js-packages/profiler-lib, MetricsView.svelte.spec.ts, etc.) — nothing under crates/connectors.

Failed job Adapter Tests / Test Adapters (amd64)
Failing test transport::kafka::ft::output::tests::real::restart_skips_a_commit_whose_reply_was_lost
Panic log line 1676: the consumer must reach the high watermark after the broker's own transaction.timeout.ms (60s) expired while the test's proxy was holding the commit reply

This is the same new Kafka FT output test feature (commit 6ad915e99, merged 2026-10-28) already flaking other merge-queue runs under issue #7760 — just a different test/symptom there (spool-not-released assertion vs. this timeout). Filed as a separate issue since the test and failure mode differ: #7765.

Next step: safe to re-queue. This looks like a timing-budget race in the test itself (proxy hold duration vs. the broker's 60s transaction.timeout.ms), unrelated to your changes.

@mihaibudiu
mihaibudiu added this pull request to the merge queue Oct 31, 2026

@Karakatiza666 Karakatiza666 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am happy we can do this

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 31, 2026
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

Same failure already explained in a previous comment on this PR: the restart_skips_a_commit_whose_reply_was_lost Kafka FT flake tracked in #7765.

PR's diff still only touches js-packages/profiler-lib, so this isn't your change. Safe to re-queue.

@mihaibudiu
mihaibudiu added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 3943447 Nov 1, 2026
1 check passed
@mihaibudiu
mihaibudiu deleted the issue7198 branch November 1, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[profiler] Deprecate the legacy profile metrics

3 participants