Repository navigation
[python] Don't assume checkpoint list order in storage details test - #7944
Open
mythical-fred-ops[bot] wants to merge 1 commit into
Open
mythical-fred-ops[bot] wants to merge 1 commit into
mythical-fred-ops[bot] wants to merge 1 commit into
Conversation
test_pipeline_storage_details_checkpoints checked that the last entry of storage_status_details.checkpoints differs from the first checkpoint. A multihost pipeline keeps two checkpoints and lists the newest first, so the last entry is the first checkpoint and the assertion fails. Look for a checkpoint with a different UUID anywhere in the list. That holds for one host or many, in any order, and still fails if no new checkpoint was made.
Member
|
Please hold this PR. The evidence does not confirm that the checkpoint list is newest-first. If the list holds only |
Member
|
Update: the multihost checkpoint list really is newest-first, while a single host lists oldest-first. The cause is in the multihost implementation, and a fix there will make both lists oldest-first. With that fix, the existing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_pipeline_storage_details_checkpointsassumedstorage_status_details.checkpointsis oldest-first.[-1] != first[-1]isfirstChange: assert that some listed checkpoint has a UUID different from
first. This works with any order and still fails if no new checkpoint was made.Checked:
pre-commit: ruff and ruff-format pass.