Repository navigation
[python] Show the checkpoint list when the storage details test fails - #7945
Merged
Merged
Conversation
test_pipeline_storage_details_checkpoints fails on multihost pipelines at `details["checkpoints"][-1] != first`. pytest cuts off the dicts in the failure message, so it is not clear whether the list held only the first checkpoint or held both in an unexpected order. Put `first` and the full list in the assertion messages, so that the next failure shows the length, order and steps of each checkpoint. Signed-off-by: Ben Pfaff <blp@feldera.com>
Contributor
|
LGTM. This only changes diagnostics: the test still asserts the same things, and the new messages will show whether the list was What I ran:
|
gz
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic only.
test_pipeline_storage_details_checkpointsfails on multihost atdetails["checkpoints"][-1] != first, and pytest cuts off the dicts, so the failure does not show which case occurred:[first]only[second, first]This change puts
firstand the full list in the assertion messages. The test logic does not change.Checked:
Related: #7944 (on hold until this gives data).