← 输入框|github.com|刷新
Skip to content

[python] Show the checkpoint list when the storage details test fails - #7945

Merged
blp merged 1 commit into
mainfrom
storage-details-checkpoints-diag
Nov 12, 2026
Merged

blp merged 1 commit into
mainfrom
storage-details-checkpoints-diag

Conversation

@blp

@blp blp commented Nov 12, 2026

Copy link
Copy Markdown
Member

Diagnostic only. test_pipeline_storage_details_checkpoints fails on multihost at details["checkpoints"][-1] != first, and pytest cuts off the dicts, so the failure does not show which case occurred:

List when read Meaning
[first] only the second checkpoint was not reported within 20 s
[second, first] the list is newest-first

This change puts first and the full list in the assertion messages. The test logic does not change.

Checked:

  • ruff check and ruff format pass.
  • Offline mock of the newest-first case: the failure message shows the full list in order.
  • I did not run the platform test, because it needs a running pipeline manager.

Related: #7944 (on hold until this gives data).

test_pipeline_storage_details_checkpoints fails on multihost pipelines
at `details["checkpoints"][-1] != first`.  pytest cuts off the dicts in
the failure message, so it is not clear whether the list held only the
first checkpoint or held both in an unexpected order.

Put `first` and the full list in the assertion messages, so that the
next failure shows the length, order and steps of each checkpoint.

Signed-off-by: Ben Pfaff <blp@feldera.com>
@blp
blp requested a review from anandbraman November 12, 2026 04:56
@blp blp self-assigned this Nov 12, 2026
@blp blp added QA Testing and quality assurance python Pull requests that update python code multihost Related to multihost or distributed pipelines fred-observe Test failure diagnosed by the fred-observe bot labels Nov 12, 2026
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This only changes diagnostics: the test still asserts the same things, and the new messages will show whether the list was [first] or [second, first].

What I ran: ruff format --check passes. ruff check reports only a pre-existing I001 import-order warning on lines this PR does not touch. I did not run the platform test (it needs a running pipeline manager).

  • tech-debt (medium, pre-existing): flaky wait. The test waits a fixed time.sleep(20) before reading the checkpoint list. That alone could explain the [first]-only case on multihost. For the real fix in [python] Don't assume checkpoint list order in storage details test #7944, poll storage_status_details() with a deadline until the newest entry differs from first, instead of sleeping. If the order turns out to be newest-first, compare against a list sorted by step, not [-1].
  • nit: print(listing) repeats the assertion message. It is only useful if you also want the list in passing runs.

@blp
blp enabled auto-merge November 12, 2026 04:59
@blp
blp disabled auto-merge November 12, 2026 06:11
@blp
blp added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 169172d Nov 12, 2026
3 checks passed
@blp
blp deleted the storage-details-checkpoints-diag branch November 12, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fred-observe Test failure diagnosed by the fred-observe bot multihost Related to multihost or distributed pipelines python Pull requests that update python code QA Testing and quality assurance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants