← 输入框|github.com|刷新
Skip to content

[python] test_samply_profile: wait up to 30 s for the profile - #7977

Merged
blp merged 1 commit into
mainfrom
samply-test-timeout
Nov 16, 2026
Merged

blp merged 1 commit into
mainfrom
samply-test-timeout

Conversation

@blp

@blp blp commented Nov 13, 2026

Copy link
Copy Markdown
Member

Under CI load, samply can take more than 5 s to stop and presymbolicate after the recording window ends. The test then failed with assert isinstance(None, bytes), although the profile arrived a few seconds later (12.9 s in the arm64 case in the issue).

  • Raise the poll timeout from 5 s to 30 s, the same grace that the macOS spawn path gives samply.
  • Sleep 0.1 s after an error reply. Before, the loop sent about 420 requests in 5 s.

Fixes https://github.com/feldera/cloud/issues/2041.

Under CI load, samply can take more than 5 s to stop and presymbolicate
after the recording window ends, so the test failed although the profile
arrived a few seconds later.  Also sleep between retries after an error
reply, instead of sending hundreds of requests per second.

Fixes feldera/cloud#2041.
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This change only touches a test. It replaces a fixed 5 s deadline with a 30 s polling deadline and adds a pause between retries, with no hard sleeps. That fits the zero-flaky-tests rule. I ran ruff check, ruff format --check and py_compile on the file and all passed. I did not run the test itself: it is enterprise-only and needs a running pipeline-manager.

@blp blp added python Pull requests that update python code QA Testing and quality assurance CI/CD profiler Issues related to the profiler and its APIs labels Nov 13, 2026
@blp blp self-assigned this Nov 13, 2026
@blp
blp added this pull request to the merge queue Nov 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 14, 2026
@blp
blp added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit e03c80d Nov 16, 2026
3 checks passed
@blp
blp deleted the samply-test-timeout branch November 16, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD profiler Issues related to the profiler and its APIs python Pull requests that update python code QA Testing and quality assurance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants