Repository navigation
Conversation
samply needs perf events. A host whose kernel.perf_event_paranoid is too high (Ubuntu's default is 4) blocks them even with the PERFMON capability, so the test failed with a 500 on local installs. Skip the test when samply's error names perf_event_paranoid; fail on any other error as before. Fixes feldera/cloud#1453.
mihaibudiu
approved these changes
Nov 16, 2026
Contributor
|
LGTM. Test-only change; no feldera-pr-checks gate fails. What I ran
pitfall (medium): the skip applies everywhere, CI included. If a CI runner image ever ships with |
A CI host that blocks perf events would otherwise skip this test on every run without notice, and samply would lose its only end-to-end test. Skip only when CI is not set.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
samply needs perf events. A host whose
kernel.perf_event_paranoidis too high (Ubuntu's default is 4) blocks them, even with the PERFMON capability that the Helm chart gives the pipeline pod. The test then fails with a 500, mostly on local installs.The new helper
_skip_if_perf_events_blocked()skips the test when the error code isSamplyProfilingFailureand the details nameperf_event_paranoid. samply prints that name in this case, and the pipeline returns samply's stderr indetails. The test calls the helper when the start request fails, and on a 500 while it polls for the profile. Any other samply error still fails the test. In CI (whenCIis set) the test never skips, so a CI host that blocks perf events fails the test instead of skipping it on every run without notice.Testing:
perf_event_paranoidmessageNot tested on a real host with
perf_event_paranoid=4.This is independent of #7977, which changes the poll timeout in the same test.
Fixes https://github.com/feldera/cloud/issues/1453.