← 输入框|github.com|刷新
Skip to content

Added Email Notifier and Email Template To Notification Hook - #386

Merged
rfelber merged 16 commits into
secureCodeBox:mainfrom
nigthknight:feature/email-notifier
May 5, 2021
Merged

rfelber merged 16 commits into
secureCodeBox:mainfrom
nigthknight:feature/email-notifier

Conversation

@nigthknight

Copy link
Copy Markdown
Member
  • Add Implementation For Email Notifier
  • Add Basic Email Template
  • Add Basic Test For Email Notifier

@nigthknight
nigthknight force-pushed the feature/email-notifier branch 2 times, most recently from 8e1bdda to 7813948 Compare April 21, 2021 11:13
@nigthknight
nigthknight force-pushed the feature/email-notifier branch from 219538d to e771ed8 Compare April 26, 2021 07:31
@nigthknight
nigthknight marked this pull request as ready for review April 26, 2021 07:44
Comment thread hooks/notification-hook/values.yaml Resolved
@nigthknight
nigthknight marked this pull request as draft April 27, 2021 13:59
@nigthknight
nigthknight force-pushed the feature/email-notifier branch from eb33359 to ec7eb69 Compare May 3, 2021 07:15
@nigthknight
nigthknight requested a review from J12934 May 3, 2021 08:44
@nigthknight
nigthknight marked this pull request as ready for review May 3, 2021 08:44
@nigthknight
nigthknight force-pushed the feature/email-notifier branch from db443f2 to 434d60f Compare May 4, 2021 07:35
@rfelber rfelber added the enhancement New feature or request label May 4, 2021
@rfelber rfelber added this to the v2.7.0 milestone May 4, 2021
Comment thread hooks/notification-hook/README.md Resolved
Comment thread hooks/notification-hook/README.md Resolved

@rfelber rfelber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and minor improvements...

@nigthknight
nigthknight requested a review from rfelber May 4, 2021 16:40
@nigthknight
nigthknight force-pushed the feature/email-notifier branch from 5d131a2 to 13432dd Compare May 4, 2021 17:57
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight and others added 7 commits May 4, 2021 19:57
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Co-authored-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@protonmail.com>
@rfelber
rfelber merged commit 62da8e2 into secureCodeBox:main May 5, 2021
@nigthknight
nigthknight deleted the feature/email-notifier branch May 6, 2021 07:15
@rfelber rfelber changed the title Add Email Notifier To Notification Hook Added Email Notifier and Email Template To Notification Hook May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚓️ Add a generic notification Hook with message templates Implement a Email Notification Hook

3 participants