Repository navigation
Conversation
This results in a reduction of up to 50% in regeneration duration since it only prunes sequentially. Pruning should be further optimised so that it avoid traversing the full request and constraint list for every group again.
…rge-conflict # Conflicts: # src/generate.cpp Co-authored-by: phkahler <14852918+phkahler@users.noreply.github.com>
Member
|
This request indicated it was being handled by GPT6 Astra. It seems to be absolute garbage. |
Member
|
I guess it's not as bad as I thought. The tests are failing on the regression test: NG test core/prune/failed_solve_keeps_constraints for PR #1744 which is why the original PR here had conflicts. |
Member
|
Replaced by #1798 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1688’s non-recursive regeneration changes conflicted with newer pruning logic on
master. This merge reconciles the generation flow while preserving the updated tag-reset behavior.src/generate.cpp.RegenerateGroupOrder.