Repository navigation
generate: make GenerateAll non recursive and optimise pruning logic - #1798
Merged
Merged
Conversation
This results in a reduction of up to 50% in regeneration duration since it only prunes sequentially. Pruning should be further optimised so that it avoid traversing the full request and constraint list for every group again. Constraints tagged for pruning are removed just before each group is solved, and the tags are cleared after solving, because the solver uses the same tags to mark the constraints it couldn't satisfy. Otherwise the constraints that failed to solve would be deleted at the end of the pass.
Closed
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in a reduction of up to 50% in regeneration duration since it only prunes sequentially. Pruning should be further optimised so that it avoid traversing the full request and constraint list for every group again.
Constraints tagged for pruning are removed just before each group is solved, and the tags are cleared after solving, because the solver uses the same tags to mark the constraints it couldn't satisfy. Otherwise the constraints that failed to solve would be deleted at the end of the pass.
@ruevs This is the original 1688 PR with fixes due to the merge conflict all squashed back down to a single commit. It is 1795 squashed if you want to see the whole history there. Sorry, 1797.