feat: Add structured audit logging for MCP feature server by SIDDHESH1564 · Pull Request #6456 · feast-dev/feast

SIDDHESH1564 · 2026-05-30T17:59:21Z

What this PR does / why we need it:

This PR adds structured audit logging in JSONL format for the Python MCP feature server.

Previously, the MCP integration only logged startup events and errors. Operators did not have a unified audit trail for MCP tool calls, internal REST requests, authentication results, authorization decisions, or request correlation.

This change introduces an audit_logging configuration section under feature_server and adds structured audit events for:

MCP tool invocations
MCP JSON-RPC requests
REST endpoint requests
Authentication outcomes
Authorization decisions
Request correlation through X-Request-Id
Client IP address and transport metadata

Each audit event follows a stable schema and includes:

event_type
UTC timestamp
request_id
principal (username, roles, and auth_type)
source (ip and transport)
action (MCP tool name and/or HTTP path)
resource (type, name, and permitted actions)
outcome
duration_ms

Sensitive data is intentionally excluded from audit logs. Tokens, entity rows, feature values, and request payloads are not logged.

Audit logging layers

Layer	Scope	Event types
`McpAuditMiddleware`	`/mcp` JSON-RPC requests	`mcp.tools.call`, `mcp.request`
`AuditLoggingMiddleware`	REST endpoints such as `/get-online-features` and `/push`	`http.request`
`AuditLogger` helpers	Authentication and authorization hooks	`authn.success`, `authn.failure`, `authz.decision`

New files

sdk/python/feast/audit/audit_logger.py
- Adds the AuditEvent model.
- Adds sink abstractions: StdoutAuditSink, FileAuditSink, and LoggerAuditSink.
- Adds AuditLogger helper methods for MCP, HTTP, authentication, and authorization events.
sdk/python/feast/audit/audit_middleware.py
- Adds AuditLoggingMiddleware for REST endpoint auditing.
- Adds McpAuditMiddleware for MCP JSON-RPC request auditing.

Modified files

sdk/python/feast/infra/feature_servers/base_config.py
- Adds AuditLoggingConfig to BaseFeatureServerConfig.
sdk/python/feast/feature_server.py
- Initializes the audit logger lifecycle.
- Wires the audit middleware into get_app().

Example configuration

feature_server:
  type: mcp
  mcp_enabled: true
  audit_logging:
    enabled: true
    sink: stdout          # stdout | file | logger
    # file_path: /var/log/feast_audit.jsonl
    log_successful_reads: true

Example JSONL event

{
  "event_type": "mcp.tools.call",
  "timestamp": "2026-05-28T12:00:00.000Z",
  "request_id": "...",
  "principal": {
    "username": "jane@co.com",
    "roles": ["reader"],
    "auth_type": "oidc"
  },
  "source": {
    "ip": "10.0.0.1",
    "transport": "mcp-http"
  },
  "action": {
    "mcp_tool": "get_online_features",
    "path": "/mcp"
  },
  "outcome": "success",
  "duration_ms": 42.0
}

Which issue(s) this PR fixes:

Fixes #6452

Checks

I've made sure the tests are passing.
My commits are signed off (git commit -s)
My PR title follows conventional commits format

Testing Strategy

Unit tests
Integration tests
Manual tests
Testing is not required for this change

Added 37 unit tests covering:

AuditEvent serialization in JSONL format, including exclusion of None values
AuditLogger helpers:
- log_mcp_call
- log_http_request
- log_authn
- log_authz
Suppression of successful read events when log_successful_reads: false
All supported sinks:
- StdoutAuditSink
- FileAuditSink
- LoggerAuditSink
create_audit_logger_from_config factory behavior and fallback handling
AuditLoggingConfig validation and inheritance through McpFeatureServerConfig
AuditLoggingMiddleware behavior:
- HTTP request logging
- Health and MCP route skipping
- Error outcomes
- X-Request-Id propagation
- Resource mapping
McpAuditMiddleware behavior:
- MCP tool-call extraction from JSON-RPC request bodies
- Generic MCP request logging
- Non-JSON request-body handling

Misc

audit_logging is defined on BaseFeatureServerConfig, making it available to both local and MCP feature server types.
Principal metadata is extracted from the existing SecurityManager context and supports no_auth, oidc, and kubernetes authentication modes.
Registry MCP parity and an OpenTelemetry sink are intentionally left as follow-up improvements, as noted in the linked issue.

ntkathole · 2026-05-31T15:34:15Z

@SIDDHESH1564

Registry MCP parity and an OpenTelemetry sink are intentionally left as follow-up improvements, as noted in the linked issue.

OTel is a follow-up is fine, but the core schema and sink abstraction feel like reinventing what opentelemetry-sdk already provides. Also, AuditEvent should carry a trace_id/span_id if OpenTelemetry is active.

Also, the fundamental problem with this is that it intercepts at the HTTP transport layer rather than at the MCP protocol layer. It should implement bidirectional correlation - linking a request to its response.

SIDDHESH1564 · 2026-05-31T17:19:43Z

Thanks for the review, @ntkathole. Both points have been addressed.

Added trace_id and span_id to AuditEvent, populated from the active OTel span when available.
Added MCP request-response correlation using the JSON-RPC id.
Added response-body inspection for JSON-RPC errors and a separate mcp_error outcome.

SIDDHESH1564 · 2026-06-01T15:47:45Z

Will update the tests accordingly and push the revised commit once the changes are complete. Thanks!

patelchaitany · 2026-06-04T11:04:36Z

@SIDDHESH1564

Suggestion:

It might help to generate request_id once in the tools/call wrapper and propagate the same value to the internal REST call (e.g. via X-Request-Id and FastApiMCP(headers=[..., "x-request-id"])). Right now the MCP path always mints a new ID while REST reads the header, and most MCP clients don’t send X-Request-Id, so mcp.tools.call and http.request may not correlate in SIEM. Worth keeping jsonrpc_id separate from audit request_id. A test that both events share one request_id per tool call would be great.

SIDDHESH1564 · 2026-06-06T18:55:21Z

@patelchaitany The mcp.tools.call and http.request events currently get independent request_id values, so they won't correlate in SIEM. Will add "x-request-id" to FastApiMCP's forwarded headers and propagate the audit request_id from the wrapper into the internal REST call. jsonrpc_id is already kept separate from request_id.

SIDDHESH1564 · 2026-06-06T19:02:41Z

Now the flow is:

audited_call_tool generates request_id = "aaa-111-..." and stores it in mcp_audit_request_id ContextVar.
Calls original(ctx, params) → fastapi_mcp makes internal httpx request to /get-online-features.
AuditLoggingMiddleware runs, checks ContextVar first:
propagated_id = mcp_audit_request_id.get() → "aaa-111-..."
request_id = propagated_id or ...
Both events now have request_id = "aaa-111-..."
ContextVar is reset in finally so it doesn't leak to subsequent requests.

patelchaitany · 2026-06-08T10:01:30Z

@SIDDHESH1564 - have you tested this locally by running the Feast feature server and checking audit logs end-to-end?

My setup: fastapi-mcp==0.4.0, mcp==1.27.0, MCP enabled with mcp_transport: http and audit_logging enabled (file sink).

What I see: REST audit (http.request) works, but MCP tool-call audit does not. On startup I get: Cannot wrap MCP call_tool handler: _request_handlers not found The wrapper never attaches — the handler stays handler, not audited_call_tool — so no mcp.tools.call events are emitted. Unit tests pass because they mock _request_handlers["tools/call"], which doesn’t exist in 0.4.0.

Root cause: The PR wraps mcp.server._request_handlers["tools/call"], but in fastapi-mcp 0.4.0 + mcp 1.x the hook is mcp.server.request_handlers[CallToolRequest] with signature async def handler(req: CallToolRequest).

Suggested fix: Update _wrap_call_tool_handler() in mcp_server.py to wrap request_handlers[CallToolRequest], read principal from server.request_context, and forward x-request-id / x-feast-auth-type in FastApiMCP(headers=...). Add a unit test using a real FastApiMCP instance (not a mocked _request_handlers).

SIDDHESH1564 · 2026-06-08T11:18:17Z

Thanks for the detailed report, @patelchaitany. you're right about the root cause. I've confirmed and fixed the issue.

The wrapper was targeting mcp.server._request_handlers["tools/call"], which was the internal API of an older mcp SDK.

patelchaitany · 2026-06-16T12:06:18Z

lgtm, @ntkathole

codecov-commenter · 2026-07-23T19:00:53Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 89.61938% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.42%. Comparing base (367001b) to head (f7b3e04).

Files with missing lines	Patch %	Lines
sdk/python/feast/audit/audit_middleware.py	81.48%	6 Missing and 4 partials ⚠️
sdk/python/feast/infra/mcp_servers/mcp_server.py	86.56%	6 Missing and 3 partials ⚠️
sdk/python/feast/audit/audit_logger.py	95.68%	3 Missing and 3 partials ⚠️
sdk/python/feast/feature_server.py	70.58%	4 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6456      +/-   ##
==========================================
+ Coverage   47.19%   47.42%   +0.23%     
==========================================
  Files         419      421       +2     
  Lines       51964    52249     +285     
  Branches     7548     7582      +34     
==========================================
+ Hits        24522    24777     +255     
- Misses      25689    25708      +19     
- Partials     1753     1764      +11

Flag	Coverage Δ
go-feature-server	`30.58% <ø> (ø)`
python-unit	`48.74% <89.61%> (+0.24%)`	⬆️

Files with missing lines	Coverage Δ
.../python/feast/infra/feature_servers/base_config.py	`100.00% <100.00%> (ø)`
sdk/python/feast/feature_server.py	`62.92% <70.58%> (+0.02%)`	⬆️
sdk/python/feast/audit/audit_logger.py	`95.68% <95.68%> (ø)`
sdk/python/feast/infra/mcp_servers/mcp_server.py	`85.92% <86.56%> (+0.63%)`	⬆️
sdk/python/feast/audit/audit_middleware.py	`81.48% <81.48%> (ø)`

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367001b...f7b3e04. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SIDDHESH1564 · 2026-07-29T18:02:08Z

@ntkathole Please review this PR at your convenience. Thanks!

SIDDHESH1564 · 2026-09-16T21:17:44Z

@ntkathole please review this PR. Thanks!

Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

…orrelation Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

…lock Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

# [0.67.0](v0.66.0...v0.67.0) (2026-10-13) ### Bug Fixes * Allow dill 0.4 so UDF serialization works on Python 3.14 ([#6858](#6858)) ([139704f](139704f)) * Allow serving features while a feature view is MATERIALIZING ([#6789](#6789)) ([e2d7fe2](e2d7fe2)), closes [#6780](#6780) * Allowlist the pinned commit SHA flagged by detect-secrets ([4b81d18](4b81d18)) * Apply point-in-time filter correctly with the Polars backend ([#6992](#6992)) ([01224d0](01224d0)) * Authorize registry server writes before deserializing UDFs ([e0ef16e](e0ef16e)) * Automate versioned documentation publication ([#6763](#6763)) ([5ad5592](5ad5592)), closes [#6762](#6762) * Avoid NumPy generic-unit deprecation when importing feast.type_map ([5fea698](5fea698)) * Bind metrics, REST registry, ui, and lineage servers dual-stack ([#6886](#6886)) ([8d2773c](8d2773c)) * Bound Arrow Flight batch size in the offline server ([#6896](#6896)) ([d169238](d169238)) * Compute std and var correctly for tiled aggregations ([213a130](213a130)) * Convert PdfBytes values to protos like ImageBytes ([#6968](#6968)) ([af20fe4](af20fe4)) * Decode fixed_size_list as the matching Feast list value type ([#6944](#6944)) ([8cfe891](8cfe891)) * Do not log /metrics requests from the pre-fork metrics server thread ([7087f1f](7087f1f)), closes [#6928](#6928) * Don't return from finally blocks in REST registry helpers ([d7cb4d0](d7cb4d0)) * Encode non-finite floats in feature server JSON responses ([#6930](#6930)) ([211ecb8](211ecb8)) * Feature freshness logic updated ([#6765](#6765)) ([f0bc070](f0bc070)) * Fix monitoring auth ([015cc84](015cc84)) * Handle non-nanosecond timestamps in tiled aggregations ([b8989cb](b8989cb)) * Improve feature list column sizing ([#6793](#6793)) ([2573693](2573693)) * Include vector attributes in Field equality ([#6934](#6934)) ([298c3f6](298c3f6)) * Increase feast container probe timeouts to avoid false restarts ([e8dbd50](e8dbd50)) * Infer the tensor type from retrieved values in to_tensor ([a03e323](a03e323)) * Infer timestamps for datetime columns in any unit or timezone ([810391f](810391f)) * Infer vector width when vector_length is undeclared ([0056565](0056565)), closes [#6907](#6907) * Initialize auth managers in standalone lineage server ([#6873](#6873)) ([ecd0d38](ecd0d38)) * Keep a zero watermark delay threshold on a Kafka source ([e2e28c7](e2e28c7)) * Keep entity rows apart in the ibis point-in-time join ([a87c070](a87c070)) * Keep the BatchFeatureView type and settings when copying it ([#6989](#6989)) ([013fc57](013fc57)) * Keep tiling, offline and stream engine settings when copying a StreamFeatureView ([fac0f88](fac0f88)) * Limit tiled max and min aggregations to the window ([2583c45](2583c45)) * Load Milvus collections once instead of on every query ([#6882](#6882)) ([f9e91fa](f9e91fa)) * Make vector length validation reachable, schema-driven and vectorized ([#6909](#6909)) ([29af8c0](29af8c0)), closes [#6907](#6907) * Map INT32_LIST, PDF_BYTES and IMAGE_BYTES type names to their ValueType ([8c1e825](8c1e825)) * Map narrow and unsigned Arrow integer types to Feast value types ([#6960](#6960)) ([ae74360](ae74360)) * Map Spark smallint and tinyint columns to INT32 ([9d42729](9d42729)) * Map SQL Server bigint to INT64 and float to DOUBLE ([6d15533](6d15533)) * Map Trino DECIMAL columns to pyarrow decimal128 ([155bc24](155bc24)) * Normalize Arrow-backed dtypes from Ray Dataset.to_pandas() for pyarrow >=25 compatibility ([#6916](#6916)) ([374f1d7](374f1d7)) * **operator:** Set grpc appProtocol on the offline Service port ([f9dcfb5](f9dcfb5)) * Pin expected tensor to same device in online retrieval test ([#6777](#6777)) ([1f2584d](1f2584d)) * Preserve an unset aggregation time window across a proto round-trip ([2000379](2000379)) * Preserve entity row order in precomputed reads ([ce37029](ce37029)) * Pull the MinIO test image from pgsty/minio ([fe27230](fe27230)) * Pull the MinIO test image from quay ([#6838](#6838)) ([367001b](367001b)) * Raise Trino monitoring query errors other than a missing table ([6161766](6161766)) * Read Kafka and Kinesis sources without a batch source from proto ([a620f5c](a620f5c)) * Read naive datetimes as UTC in UnixTimestamp values ([bc703d9](bc703d9)) * Record which storage class wrote a custom_storage payload ([#6988](#6988)) ([c0545f7](c0545f7)) * Refresh the SQL registry cache after deleting a data source ([66c55e3](66c55e3)) * Refresh the SQL registry cache after deleting a permission ([6b212f5](6b212f5)) * Reject unknown resource types and actions in the REST permission API ([a5eaa36](a5eaa36)) * Remove pip install command from Redis GLIDE docstring ([66ff990](66ff990)) * Remove runtime pip install hints from mlflow errors ([dd9f099](dd9f099)) * Remove unsupported vector_len from PostgreSQL tutorial config ([fcc9a85](fcc9a85)) * Repair Chronon operator validation and Pixi CI setup ([#6947](#6947)) ([3710f78](3710f78)) * Report Dask monitoring read errors instead of no data ([81673d9](81673d9)) * Resolve feature view batch source name against registry ([f8883d0](f8883d0)) * Restrict UI server CORS to trusted origins ([#6986](#6986)) ([5e7ef3e](5e7ef3e)) * Return feature_view_metadata from the REST feature server ([#6927](#6927)) ([bc5aeef](bc5aeef)) * Serve aliased on demand feature views in feature services ([823b92e](823b92e)) * Snapshot tag filters in registry cache keys ([81e1546](81e1546)) * Stabilize materialization checks across hour boundaries ([#6948](#6948)) ([acadb17](acadb17)) * Stop the Couchbase online store reporting failed writes as written ([b3f3c98](b3f3c98)) * Support SQL registry dump ([b60f9c7](b60f9c7)) * Treat datetimes with a None utcoffset as naive ([687bee8](687bee8)) * Unwrap SecretStr tokens when building Trino auth objects ([#6771](#6771)) ([922db5c](922db5c)) * Use a valid ShuffleStrategy for the Ray DatasetContext ([6259f5c](6259f5c)) * Use do_exchange for offline server reads to support HPA ([bae07fc](bae07fc)) * Use group_by in Polars backend aggregation ([#6965](#6965)) ([7b9fad2](7b9fad2)) * Use upstream kubectl image as feast-operator CronJob default ([d6cc1dc](d6cc1dc)) * Use UTC end bound and correct docs for disable_event_timestamp ([#6956](#6956)) ([cc07c82](cc07c82)), closes [#6936](#6936) ### Features * Add a non-JVM read path for Lance data sources ([#6943](#6943)) ([e2a53bb](e2a53bb)), closes [#6925](#6925) [#5782](#5782) [#6909](#6909) * Add a non-JVM write path for Lance data sources ([#6945](#6945)) ([f754323](f754323)), closes [#6943](#6943) [#6909](#6909) * Add Chronon online and offline store integrations ([#6188](#6188)) ([dd059c6](dd059c6)) * Add consistency_level to the Milvus online store config ([97296c1](97296c1)) * Add dualStack server option to the Feast operator ([#6887](#6887)) ([725a147](725a147)), closes [#6977](#6977) * Add Lance optional dependencies ([#6958](#6958)) ([20bc993](20bc993)) * Add LanceFormat table format with version/tag pinning ([1196e22](1196e22)), closes [#5650](#5650) * Add MLflow as a first-class offline DataSource for Feast ([#6702](#6702)) ([3667772](3667772)) * Add optional GLIDE client for Redis online reads ([#6870](#6870)) ([6e9a532](6e9a532)) * Add quality monitoring features for Trino offline store ([#6779](#6779)) ([9340545](9340545)) * Add SavedDatasetLanceStorage ([1118d3e](1118d3e)) * Add standalone MCP server as a first-class component ([0efab5c](0efab5c)), closes [python-keycloak#623](https://github.com/python-keycloak/issues/623) * Add structured audit logging for MCP feature server ([#6456](#6456)) ([640ac70](640ac70)) * Add Trino compute engine for batch retrieval and materialization ([#6898](#6898)) ([11a47b4](11a47b4)) * Batch Postgres online reads across feature views ([#6832](#6832)) ([514bee7](514bee7)), closes [#3259](#3259) * **bigtable:** Make write batch size and concurrency configurable ([#6847](#6847)) ([5388522](5388522)) * Bucket feature count labels in latency metrics ([#6811](#6811)) ([d9ea120](d9ea120)) * Expose runtime version in Feast UI ([#6843](#6843)) ([fa8f06b](fa8f06b)) * Make Milvus index and search params configurable ([ef743ff](ef743ff)) * Offline write batch for IcebergSource ([5be5ed0](5be5ed0)) * OpenLineage consumer improvements - dataset versioning, column lineage, ownership ([69f294e](69f294e)) * **operator:** Add tolerations and nodeSelector to the FeatureStore CR ([#6741](#6741)) ([03dac6f](03dac6f)) * Serve the MCP server dual-stack on --host :: ([4fc9726](4fc9726)) * Support Milvus partition keys in the Milvus online store ([0ed3285](0ed3285)) * Support token, uri and db_name in the Milvus online store ([c5efecd](c5efecd)) * Version-pinning for FeatureService (online + offline) ([#6718](#6718)) ([787845a](787845a)) ### Performance Improvements * Avoid pandas copy in Spark reads ([#6878](#6878)) ([4771156](4771156)) * Decouple metrics HTTP server into a dedicated child process ([#6855](#6855)) ([0b621de](0b621de)) * Reduce online serving hot-path overhead from metrics and audit logging ([5ee7ee3](5ee7ee3))

* fix: Increase feast container probe timeouts to avoid false restarts Signed-off-by: Srihari <svenkata@redhat.com> * chore: Remove unused hermeto offline tree and sdist requirement locks (feast-dev#6987) * chore: Remove unused multicloud hermeto offline build tree Drop sdk/python/feast/infra/feature_servers/multicloud/offline/, which only supported local hermeto/arrow-from-source and RPM lock offline image builds and is unused by Makefile CI, GitHub Actions, or the standard feature-server Dockerfiles. Also clear related .secrets.baseline entries. Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * chore: Drop unused minimal-sdist requirement locks Remove py3.10–3.12 minimal-sdist(-build) lockfiles, stop generating them in lock-python-dependencies-all, and delete the minimal-sdist-build extra. They only supported hermeto build-from-sdist offline image builds. Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * chore: Refresh pixi.lock after removing minimal-sdist-build Keep pixi install --locked in sync with the pyproject.toml optional dependency change so ray/duckdb CI environments can install. Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * chore(release): release 0.67.0 # [0.67.0](feast-dev/feast@v0.66.0...v0.67.0) (2026-10-13) ### Bug Fixes * Allow dill 0.4 so UDF serialization works on Python 3.14 ([feast-dev#6858](feast-dev#6858)) ([139704f](feast-dev@139704f)) * Allow serving features while a feature view is MATERIALIZING ([feast-dev#6789](feast-dev#6789)) ([e2d7fe2](feast-dev@e2d7fe2)), closes [feast-dev#6780](feast-dev#6780) * Allowlist the pinned commit SHA flagged by detect-secrets ([4b81d18](feast-dev@4b81d18)) * Apply point-in-time filter correctly with the Polars backend ([feast-dev#6992](feast-dev#6992)) ([01224d0](feast-dev@01224d0)) * Authorize registry server writes before deserializing UDFs ([e0ef16e](feast-dev@e0ef16e)) * Automate versioned documentation publication ([feast-dev#6763](feast-dev#6763)) ([5ad5592](feast-dev@5ad5592)), closes [feast-dev#6762](feast-dev#6762) * Avoid NumPy generic-unit deprecation when importing feast.type_map ([5fea698](feast-dev@5fea698)) * Bind metrics, REST registry, ui, and lineage servers dual-stack ([feast-dev#6886](feast-dev#6886)) ([8d2773c](feast-dev@8d2773c)) * Bound Arrow Flight batch size in the offline server ([feast-dev#6896](feast-dev#6896)) ([d169238](feast-dev@d169238)) * Compute std and var correctly for tiled aggregations ([213a130](feast-dev@213a130)) * Convert PdfBytes values to protos like ImageBytes ([feast-dev#6968](feast-dev#6968)) ([af20fe4](feast-dev@af20fe4)) * Decode fixed_size_list as the matching Feast list value type ([feast-dev#6944](feast-dev#6944)) ([8cfe891](feast-dev@8cfe891)) * Do not log /metrics requests from the pre-fork metrics server thread ([7087f1f](feast-dev@7087f1f)), closes [feast-dev#6928](feast-dev#6928) * Don't return from finally blocks in REST registry helpers ([d7cb4d0](feast-dev@d7cb4d0)) * Encode non-finite floats in feature server JSON responses ([feast-dev#6930](feast-dev#6930)) ([211ecb8](feast-dev@211ecb8)) * Feature freshness logic updated ([feast-dev#6765](feast-dev#6765)) ([f0bc070](feast-dev@f0bc070)) * Fix monitoring auth ([015cc84](feast-dev@015cc84)) * Handle non-nanosecond timestamps in tiled aggregations ([b8989cb](feast-dev@b8989cb)) * Improve feature list column sizing ([feast-dev#6793](feast-dev#6793)) ([2573693](feast-dev@2573693)) * Include vector attributes in Field equality ([feast-dev#6934](feast-dev#6934)) ([298c3f6](feast-dev@298c3f6)) * Increase feast container probe timeouts to avoid false restarts ([e8dbd50](feast-dev@e8dbd50)) * Infer the tensor type from retrieved values in to_tensor ([a03e323](feast-dev@a03e323)) * Infer timestamps for datetime columns in any unit or timezone ([810391f](feast-dev@810391f)) * Infer vector width when vector_length is undeclared ([0056565](feast-dev@0056565)), closes [feast-dev#6907](feast-dev#6907) * Initialize auth managers in standalone lineage server ([feast-dev#6873](feast-dev#6873)) ([ecd0d38](feast-dev@ecd0d38)) * Keep a zero watermark delay threshold on a Kafka source ([e2e28c7](feast-dev@e2e28c7)) * Keep entity rows apart in the ibis point-in-time join ([a87c070](feast-dev@a87c070)) * Keep the BatchFeatureView type and settings when copying it ([feast-dev#6989](feast-dev#6989)) ([013fc57](feast-dev@013fc57)) * Keep tiling, offline and stream engine settings when copying a StreamFeatureView ([fac0f88](feast-dev@fac0f88)) * Limit tiled max and min aggregations to the window ([2583c45](feast-dev@2583c45)) * Load Milvus collections once instead of on every query ([feast-dev#6882](feast-dev#6882)) ([f9e91fa](feast-dev@f9e91fa)) * Make vector length validation reachable, schema-driven and vectorized ([feast-dev#6909](feast-dev#6909)) ([29af8c0](feast-dev@29af8c0)), closes [feast-dev#6907](feast-dev#6907) * Map INT32_LIST, PDF_BYTES and IMAGE_BYTES type names to their ValueType ([8c1e825](feast-dev@8c1e825)) * Map narrow and unsigned Arrow integer types to Feast value types ([feast-dev#6960](feast-dev#6960)) ([ae74360](feast-dev@ae74360)) * Map Spark smallint and tinyint columns to INT32 ([9d42729](feast-dev@9d42729)) * Map SQL Server bigint to INT64 and float to DOUBLE ([6d15533](feast-dev@6d15533)) * Map Trino DECIMAL columns to pyarrow decimal128 ([155bc24](feast-dev@155bc24)) * Normalize Arrow-backed dtypes from Ray Dataset.to_pandas() for pyarrow >=25 compatibility ([feast-dev#6916](feast-dev#6916)) ([374f1d7](feast-dev@374f1d7)) * **operator:** Set grpc appProtocol on the offline Service port ([f9dcfb5](feast-dev@f9dcfb5)) * Pin expected tensor to same device in online retrieval test ([feast-dev#6777](feast-dev#6777)) ([1f2584d](feast-dev@1f2584d)) * Preserve an unset aggregation time window across a proto round-trip ([2000379](feast-dev@2000379)) * Preserve entity row order in precomputed reads ([ce37029](feast-dev@ce37029)) * Pull the MinIO test image from pgsty/minio ([fe27230](feast-dev@fe27230)) * Pull the MinIO test image from quay ([feast-dev#6838](feast-dev#6838)) ([367001b](feast-dev@367001b)) * Raise Trino monitoring query errors other than a missing table ([6161766](feast-dev@6161766)) * Read Kafka and Kinesis sources without a batch source from proto ([a620f5c](feast-dev@a620f5c)) * Read naive datetimes as UTC in UnixTimestamp values ([bc703d9](feast-dev@bc703d9)) * Record which storage class wrote a custom_storage payload ([feast-dev#6988](feast-dev#6988)) ([c0545f7](feast-dev@c0545f7)) * Refresh the SQL registry cache after deleting a data source ([66c55e3](feast-dev@66c55e3)) * Refresh the SQL registry cache after deleting a permission ([6b212f5](feast-dev@6b212f5)) * Reject unknown resource types and actions in the REST permission API ([a5eaa36](feast-dev@a5eaa36)) * Remove pip install command from Redis GLIDE docstring ([66ff990](feast-dev@66ff990)) * Remove runtime pip install hints from mlflow errors ([dd9f099](feast-dev@dd9f099)) * Remove unsupported vector_len from PostgreSQL tutorial config ([fcc9a85](feast-dev@fcc9a85)) * Repair Chronon operator validation and Pixi CI setup ([feast-dev#6947](feast-dev#6947)) ([3710f78](feast-dev@3710f78)) * Report Dask monitoring read errors instead of no data ([81673d9](feast-dev@81673d9)) * Resolve feature view batch source name against registry ([f8883d0](feast-dev@f8883d0)) * Restrict UI server CORS to trusted origins ([feast-dev#6986](feast-dev#6986)) ([5e7ef3e](feast-dev@5e7ef3e)) * Return feature_view_metadata from the REST feature server ([feast-dev#6927](feast-dev#6927)) ([bc5aeef](feast-dev@bc5aeef)) * Serve aliased on demand feature views in feature services ([823b92e](feast-dev@823b92e)) * Snapshot tag filters in registry cache keys ([81e1546](feast-dev@81e1546)) * Stabilize materialization checks across hour boundaries ([feast-dev#6948](feast-dev#6948)) ([acadb17](feast-dev@acadb17)) * Stop the Couchbase online store reporting failed writes as written ([b3f3c98](feast-dev@b3f3c98)) * Support SQL registry dump ([b60f9c7](feast-dev@b60f9c7)) * Treat datetimes with a None utcoffset as naive ([687bee8](feast-dev@687bee8)) * Unwrap SecretStr tokens when building Trino auth objects ([feast-dev#6771](feast-dev#6771)) ([922db5c](feast-dev@922db5c)) * Use a valid ShuffleStrategy for the Ray DatasetContext ([6259f5c](feast-dev@6259f5c)) * Use do_exchange for offline server reads to support HPA ([bae07fc](feast-dev@bae07fc)) * Use group_by in Polars backend aggregation ([feast-dev#6965](feast-dev#6965)) ([7b9fad2](feast-dev@7b9fad2)) * Use upstream kubectl image as feast-operator CronJob default ([d6cc1dc](feast-dev@d6cc1dc)) * Use UTC end bound and correct docs for disable_event_timestamp ([feast-dev#6956](feast-dev#6956)) ([cc07c82](feast-dev@cc07c82)), closes [feast-dev#6936](feast-dev#6936) ### Features * Add a non-JVM read path for Lance data sources ([feast-dev#6943](feast-dev#6943)) ([e2a53bb](feast-dev@e2a53bb)), closes [feast-dev#6925](feast-dev#6925) [feast-dev#5782](feast-dev#5782) [feast-dev#6909](feast-dev#6909) * Add a non-JVM write path for Lance data sources ([feast-dev#6945](feast-dev#6945)) ([f754323](feast-dev@f754323)), closes [feast-dev#6943](feast-dev#6943) [feast-dev#6909](feast-dev#6909) * Add Chronon online and offline store integrations ([feast-dev#6188](feast-dev#6188)) ([dd059c6](feast-dev@dd059c6)) * Add consistency_level to the Milvus online store config ([97296c1](feast-dev@97296c1)) * Add dualStack server option to the Feast operator ([feast-dev#6887](feast-dev#6887)) ([725a147](feast-dev@725a147)), closes [feast-dev#6977](feast-dev#6977) * Add Lance optional dependencies ([feast-dev#6958](feast-dev#6958)) ([20bc993](feast-dev@20bc993)) * Add LanceFormat table format with version/tag pinning ([1196e22](feast-dev@1196e22)), closes [feast-dev#5650](feast-dev#5650) * Add MLflow as a first-class offline DataSource for Feast ([feast-dev#6702](feast-dev#6702)) ([3667772](feast-dev@3667772)) * Add optional GLIDE client for Redis online reads ([feast-dev#6870](feast-dev#6870)) ([6e9a532](feast-dev@6e9a532)) * Add quality monitoring features for Trino offline store ([feast-dev#6779](feast-dev#6779)) ([9340545](feast-dev@9340545)) * Add SavedDatasetLanceStorage ([1118d3e](feast-dev@1118d3e)) * Add standalone MCP server as a first-class component ([0efab5c](feast-dev@0efab5c)), closes [python-keycloak#623](https://github.com/python-keycloak/issues/623) * Add structured audit logging for MCP feature server ([feast-dev#6456](feast-dev#6456)) ([640ac70](feast-dev@640ac70)) * Add Trino compute engine for batch retrieval and materialization ([feast-dev#6898](feast-dev#6898)) ([11a47b4](feast-dev@11a47b4)) * Batch Postgres online reads across feature views ([feast-dev#6832](feast-dev#6832)) ([514bee7](feast-dev@514bee7)), closes [feast-dev#3259](feast-dev#3259) * **bigtable:** Make write batch size and concurrency configurable ([feast-dev#6847](feast-dev#6847)) ([5388522](feast-dev@5388522)) * Bucket feature count labels in latency metrics ([feast-dev#6811](feast-dev#6811)) ([d9ea120](feast-dev@d9ea120)) * Expose runtime version in Feast UI ([feast-dev#6843](feast-dev#6843)) ([fa8f06b](feast-dev@fa8f06b)) * Make Milvus index and search params configurable ([ef743ff](feast-dev@ef743ff)) * Offline write batch for IcebergSource ([5be5ed0](feast-dev@5be5ed0)) * OpenLineage consumer improvements - dataset versioning, column lineage, ownership ([69f294e](feast-dev@69f294e)) * **operator:** Add tolerations and nodeSelector to the FeatureStore CR ([feast-dev#6741](feast-dev#6741)) ([03dac6f](feast-dev@03dac6f)) * Serve the MCP server dual-stack on --host :: ([4fc9726](feast-dev@4fc9726)) * Support Milvus partition keys in the Milvus online store ([0ed3285](feast-dev@0ed3285)) * Support token, uri and db_name in the Milvus online store ([c5efecd](feast-dev@c5efecd)) * Version-pinning for FeatureService (online + offline) ([feast-dev#6718](feast-dev#6718)) ([787845a](feast-dev@787845a)) ### Performance Improvements * Avoid pandas copy in Spark reads ([feast-dev#6878](feast-dev#6878)) ([4771156](feast-dev@4771156)) * Decouple metrics HTTP server into a dedicated child process ([feast-dev#6855](feast-dev#6855)) ([0b621de](feast-dev@0b621de)) * Reduce online serving hot-path overhead from metrics and audit logging ([5ee7ee3](feast-dev@5ee7ee3)) --------- Signed-off-by: Srihari <svenkata@redhat.com> Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Srihari <svenkata@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: feast-ci-bot <feast-ci-bot@willem.co>

SIDDHESH1564 requested a review from a team as a code owner May 30, 2026 17:59

ntkathole reviewed Jun 1, 2026

View reviewed changes

Comment thread sdk/python/feast/audit/audit_middleware.py Outdated

Comment thread sdk/python/feast/audit/audit_middleware.py

Comment thread sdk/python/feast/audit/audit_logger.py

SIDDHESH1564 requested a review from ntkathole June 3, 2026 06:32

ntkathole force-pushed the feat/mcp-audit-logging branch 2 times, most recently from d54e24d to 3ca8671 Compare July 4, 2026 04:13

SIDDHESH1564 force-pushed the feat/mcp-audit-logging branch 2 times, most recently from ae45119 to 32bfff0 Compare July 23, 2026 18:56

ntkathole force-pushed the feat/mcp-audit-logging branch from 8bfb9d1 to 094fe7c Compare July 30, 2026 07:11

ntkathole reviewed Jul 30, 2026

View reviewed changes

Comment thread sdk/python/feast/infra/mcp_servers/mcp_server.py Outdated

ntkathole reviewed Jul 30, 2026

View reviewed changes

Comment thread sdk/python/feast/infra/feature_servers/base_config.py Outdated

ntkathole reviewed Jul 30, 2026

View reviewed changes

Comment thread sdk/python/feast/audit/audit_logger.py Outdated

ntkathole reviewed Jul 30, 2026

View reviewed changes

Comment thread sdk/python/feast/audit/audit_logger.py Outdated

SIDDHESH1564 force-pushed the feat/mcp-audit-logging branch from 094fe7c to a8fefb2 Compare August 21, 2026 15:57

ntkathole added the ok-to-test label Sep 17, 2026

SIDDHESH1564 added 4 commits September 17, 2026 11:25

feat: Add structured audit logging for MCP feature server

a284b7e

Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

feat: Enhance audit logging with OpenTelemetry support and JSON-RPC c…

a0b5e1c

…orrelation Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

refactor: Audit MCP at protocol layer, fix empty principal, add emit …

5d2a7d0

…lock Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

fix(mcp): Propagate request_id for audit logging

98dbab9

Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

SIDDHESH1564 added 2 commits September 17, 2026 11:25

refactor(mcp): Update MCP server handler for audit logging

480bdfa

Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

fix: Address review feedback for audit logging

f7b3e04

Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>

ntkathole force-pushed the feat/mcp-audit-logging branch from 2e6a59c to f7b3e04 Compare September 17, 2026 05:55

ntkathole approved these changes Sep 17, 2026

View reviewed changes

ntkathole merged commit 640ac70 into feast-dev:master Sep 17, 2026
28 checks passed

patelchaitany mentioned this pull request Sep 17, 2026

chore: Sync upstream/master into master opendatahub-io/feast#217

Merged

Conversation

SIDDHESH1564 commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Audit logging layers

New files

Modified files

Example configuration

Example JSONL event

Which issue(s) this PR fixes:

Checks

Testing Strategy

Misc

Uh oh!

ntkathole commented May 31, 2026

Uh oh!

SIDDHESH1564 commented May 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SIDDHESH1564 commented Jun 1, 2026

Uh oh!

patelchaitany commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SIDDHESH1564 commented Jun 6, 2026

Uh oh!

SIDDHESH1564 commented Jun 6, 2026

Uh oh!

patelchaitany commented Jun 8, 2026

Uh oh!

SIDDHESH1564 commented Jun 8, 2026

Uh oh!

patelchaitany commented Jun 16, 2026

Uh oh!

codecov-commenter commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SIDDHESH1564 commented Jul 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SIDDHESH1564 commented Sep 16, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SIDDHESH1564 commented May 30, 2026 •

edited

Loading

patelchaitany commented Jun 4, 2026 •

edited

Loading

codecov-commenter commented Jul 23, 2026 •

edited

Loading